-
Notifications
You must be signed in to change notification settings - Fork 230
[NEW] Add Feedback form #415
base: develop
Are you sure you want to change the base?
Conversation
- Wrapped form under Screen.content container - Stacked Buttons
Merging RC develop branch with my forked develop branch
- new behaviour added - on Finish Chat redirect to Feedback form
- connected survey component with Livechat SDK - handle routing
Hello, @renatobecker All the above-mentioned tasks are completed. I think that the Livechat Widget part for this Feedback/Survey feature is complete. I'd appreciate if u could review this PR and any suggestions and feedback is most welcome:smile: A bit about the feature implemented When the user clicks on After giving feedback, the user is redirected to |
@murtaza98 I didn't review your PR in-depth yet, but I noticed the following situations:
I'll be waiting for your reply, thanks. |
When I tested the original PR, the emojis which were getting rendered were colorless. Have a look
I will work on these 2, thanks for pointing it out |
Another important thing to mention: You hardcoded the |
- this will optimize the emoji-rendering process
- removed unnecessary css import - refactored ExperienceRatingItem Component
Applied the color scheme to the feedback page
Added a new behavior, now when
Removed the dependency of emoji-mart lib. The loading of emojis is now much faster.
Implemented this, now all the options are being read from the config. Nothing is hardcoded. PS. |
rid: rid, | ||
data: data | ||
} | ||
Livechat.chatSurvey(packet).then(response => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello! I checked this PR and found an error that the comment message is not sent to the server. It depends on the server config for livechat.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @antkaz, U r correct. This PR doesn't send the comment message to the server. I tried sending it, but the server is not configured to handle it hence it was throwing an error. So in order to send the comment message, some of the interfaces and checks on the server will need to be modified.
References:
This is probably the code which will need to be modified in order to support comment message
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can help you do it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be awesome!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created new PR for ROcket.Chat RocketChat/Rocket.Chat#18280 where I fixed old survey config and added feedback form config.
Also I created PR murtaza98#2 where I fixed current code and added sending comment to Rocket.Chat server.
Feedback saves to room data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@renatobecker @murtaza98 can you review please
[FIX] send feedback comment to the server
The main goal of this PR is to add functionality to display feedback form to visitors at the end of conversation.
Tasks
Feedback form UI
PS:
Most of the code here is taken from PR #104. There have been many changes in this repo since this PR #104 was opened, so I decided to create a new PR instead of updating and merging the old one.
Project Tracker for this PR