Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement KeyID Generation Logic #5921

Merged
merged 5 commits into from
Oct 21, 2024
Merged

feat: Implement KeyID Generation Logic #5921

merged 5 commits into from
Oct 21, 2024

Conversation

diegolmello
Copy link
Member

@diegolmello diegolmello commented Oct 16, 2024 •
edited
Loading

Proposed changes

Issue(s)

RocketChat/Rocket.Chat#33615

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

E2EE2-84

@diegolmello diegolmello marked this pull request as ready for review October 17, 2024 13:13
@diegolmello diegolmello changed the title feat: room key id gen feat: Implement KeyID Generation Logic Oct 21, 2024
@diegolmello diegolmello merged commit 22d437b into develop Oct 21, 2024
2 of 4 checks passed
@diegolmello diegolmello deleted the feat.room-key-gen branch October 21, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@diegolmello