Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: missing delete channel permission on team channels #5973

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

OtavioStasiak
Copy link
Contributor

@OtavioStasiak OtavioStasiak commented Nov 9, 2024

Proposed changes

the regression was introduced here: #5943. The removal of the 'delete-c' permission from mapStateToProps caused the delete option in the TeamChannelsView action sheet to be hidden.

Issue(s)

https://rocketchat.atlassian.net/browse/NATIVE-706

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@OtavioStasiak OtavioStasiak marked this pull request as ready for review November 9, 2024 06:57
Copy link
Member

@diegolmello diegolmello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@diegolmello diegolmello changed the title fix: added deleteCPermission regression: missing delete channel permission on team channels Nov 11, 2024
@OtavioStasiak OtavioStasiak merged commit ebeaec3 into develop Nov 11, 2024
3 of 8 checks passed
@OtavioStasiak OtavioStasiak deleted the fix-team-tests branch November 11, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants