Skip to content

chore: allow Omnichannel Chats to be placed onHold even when the last message is not from the Agent #12881

chore: allow Omnichannel Chats to be placed onHold even when the last message is not from the Agent

chore: allow Omnichannel Chats to be placed onHold even when the last message is not from the Agent #12881

Triggered via pull request October 17, 2023 15:09
Status Failure
Total duration 45m 41s
Artifacts 1

ci.yml

on: pull_request
⚙️ Variables Setup
3s
⚙️ Variables Setup
📦 Build Packages
12m 2s
📦 Build Packages
Matrix: 🔎 Code Check / code-check
📦 Meteor Build - coverage
16m 58s
📦 Meteor Build - coverage
🔨 Test Unit  /  Unit Tests
2m 1s
🔨 Test Unit / Unit Tests
Matrix: 🚢 Build Docker Images for Testing
🚢 Build Docker Image (preview)
0s
🚢 Build Docker Image (preview)
Matrix: 🔨 Test API (EE) / test
Waiting for pending jobs
Matrix: 🔨 Test API (CE) / test
Waiting for pending jobs
Matrix: 🔨 Test UI (EE) / test
Waiting for pending jobs
Matrix: 🔨 Test UI (CE) / test
Waiting for pending jobs
✅ Tests Done
0s
✅ Tests Done
📦 Meteor Build - official
0s
📦 Meteor Build - official
Matrix: 🚢 Build Docker Images for Production
🚀 Publish build assets
0s
🚀 Publish build assets
Matrix: 🚀 Publish Docker Image (main)
Matrix: 🚀 Publish Docker Image (services)
🚀 Notify external services
0s
🚀 Notify external services
trigger-dependent-workflows
0s
trigger-dependent-workflows
Fit to window
Zoom out
Zoom in

Annotations

3 errors and 10 warnings
🔎 Code Check / Code Lint
@rocket.chat/meteor#lint: command (/home/runner/work/Rocket.Chat/Rocket.Chat/apps/meteor) yarn run lint exited (1)
🔎 Code Check / Code Lint: apps/meteor/client/views/room/Header/Omnichannel/QuickActions/hooks/useQuickActions.tsx#L314
Replace `!room.onHold·&&·room.u·&&·manualOnHoldAllowed·&&·(!allowManualOnHoldUponAgentEngagement·||·!(room·as·any).lastMessage?.token)` with `⏎↹↹!room.onHold·&&·room.u·&&·manualOnHoldAllowed·&&·(!allowManualOnHoldUponAgentEngagement·||·!(room·as·any).lastMessage?.token),⏎↹`
🔎 Code Check / Code Lint
Process completed with exit code 1.
🔎 Code Check / Code Lint: packages/agenda/src/Agenda.ts#L66
Do not use "@ts-ignore" because it alters compilation errors
🔎 Code Check / Code Lint: packages/agenda/src/Agenda.ts#L69
Do not use "@ts-ignore" because it alters compilation errors
🔎 Code Check / Code Lint: packages/agenda/src/Agenda.ts#L72
Do not use "@ts-ignore" because it alters compilation errors
🔎 Code Check / Code Lint: packages/agenda/src/Agenda.ts#L125
Do not use "@ts-ignore" because it alters compilation errors
🔎 Code Check / Code Lint: packages/agenda/src/Agenda.ts#L127
Do not use "@ts-ignore" because it alters compilation errors
🔎 Code Check / Code Lint: packages/agenda/src/Agenda.ts#L605
Do not use "@ts-ignore" because it alters compilation errors
🔎 Code Check / Code Lint: packages/livechat/src/components/Composer/index.tsx#L29
Prefer using an optional chain expression instead, as it's more concise and easier to read
🔎 Code Check / Code Lint: apps/meteor/app/api/server/v1/settings.ts#L106
Prefer using an optional chain expression instead, as it's more concise and easier to read

Artifacts

Produced during runtime
Name Size
build Expired
278 MB