fix(federation-v2): don't throw on username validation before creatin…

…g dm (#33280)

.changeset/fifty-parrots-wonder.md

@@ -0,0 +1,5 @@
+---
+'@rocket.chat/meteor': patch
+---
+
+Fixes an issue preventing the creation of normal direct message rooms due to an invalid federation configuration, allowing proper room creation under standard settings.

apps/meteor/server/services/federation/infrastructure/rocket-chat/hooks/index.ts

@@ -74,12 +74,10 @@ export class FederationHooks {
 		callbacks.add(
 			'federation.beforeCreateDirectMessage',
 			async (members: IUser[]): Promise<void> => {
-				if (!members) {
+				if (!members || !isFederationEnabled()) {
 					return;
 				}
 
-				throwIfFederationNotEnabledOrNotReady();
-
 				await callback(members);
 			},
 			callbacks.priority.HIGH,

apps/meteor/tests/unit/server/federation/infrastructure/rocket-chat/hooks/hooks.spec.ts

@@ -279,9 +279,18 @@ describe('Federation - Infrastructure - RocketChat - Hooks', () => {
 		it('should execute the callback when everything is correct', () => {
 			const stub = sinon.stub();
 			FederationHooks.canCreateDirectMessageFromUI(stub);
+			isFederationEnabled.returns(true);
 			hooks['federation-v2-can-create-direct-message-from-ui-ce']([]);
 			expect(stub.calledWith([])).to.be.true;
 		});
+
+		it('should not execute callback or throw error when federation is disabled', () => {
+			const stub = sinon.stub();
+			FederationHooks.canCreateDirectMessageFromUI(stub);
+			isFederationEnabled.returns(false);
+			hooks['federation-v2-can-create-direct-message-from-ui-ce']([]);
+			expect(stub.calledWith([])).to.be.false;
+		});
 	});
 
 	describe('#afterMessageReacted()', () => {