test: Validate monitors data access (#30593)

apps/meteor/ee/app/livechat-enterprise/server/lib/units.ts

@@ -8,7 +8,7 @@ async function hasUnits(): Promise<boolean> {
 }
 
 // Units should't change really often, so we can cache the result
-const memoizedHasUnits = mem(hasUnits, { maxAge: 10000 });
+const memoizedHasUnits = mem(hasUnits, { maxAge: process.env.TEST_MODE ? 1 : 10000 });
 
 export async function getUnitsFromUser(): Promise<{ [k: string]: any }[] | undefined> {
 	if (!(await memoizedHasUnits())) {

apps/meteor/ee/app/livechat-enterprise/server/methods/getUnitsFromUserRoles.ts

@@ -14,8 +14,8 @@ async function getDepartmentsFromUserRoles(user: string): Promise<string[]> {
 	return (await LivechatDepartmentAgents.findByAgentId(user).toArray()).map((department) => department.departmentId);
 }
 
-const memoizedGetUnitFromUserRoles = mem(getUnitsFromUserRoles, { maxAge: 10000 });
-const memoizedGetDepartmentsFromUserRoles = mem(getDepartmentsFromUserRoles, { maxAge: 5000 });
+const memoizedGetUnitFromUserRoles = mem(getUnitsFromUserRoles, { maxAge: process.env.TEST_MODE ? 1 : 10000 });
+const memoizedGetDepartmentsFromUserRoles = mem(getDepartmentsFromUserRoles, { maxAge: process.env.TEST_MODE ? 1 : 10000 });
 
 export const getUnitsFromUser = async (user: string): Promise<string[] | undefined> => {
 	if (!user || (await hasAnyRoleAsync(user, ['admin', 'livechat-manager']))) {

apps/meteor/tests/end-to-end/api/livechat/22-monitors.ts

@@ -0,0 +1,201 @@
+/* eslint-disable @typescript-eslint/no-non-null-assertion */
+import type { ILivechatDepartment, IUser } from '@rocket.chat/core-typings';
+import { expect } from 'chai';
+import { before, it, describe } from 'mocha';
+
+import { getCredentials, api, request } from '../../../data/api-data';
+import { addOrRemoveAgentFromDepartment, createDepartment } from '../../../data/livechat/department';
+import {
+	createAgent,
+	createLivechatRoom,
+	createManager,
+	createVisitor,
+	getLivechatRoomInfo,
+	makeAgentAvailable,
+} from '../../../data/livechat/rooms';
+import { createMonitor, createUnit } from '../../../data/livechat/units';
+import { updateSetting, updatePermission } from '../../../data/permissions.helper';
+import { password } from '../../../data/user';
+import { createUser, login, setUserActiveStatus } from '../../../data/users.helper';
+import { IS_EE } from '../../../e2e/config/constants';
+
+type TestUser = { user: IUser; credentials: { 'X-Auth-Token': string; 'X-User-Id': string } };
+
+(IS_EE ? describe : describe.skip)('Omnichannel - Monitors', () => {
+	let manager: TestUser;
+	let monitor: TestUser;
+	let noUnitDepartment: ILivechatDepartment;
+	let unitDepartment: ILivechatDepartment;
+
+	before((done) => getCredentials(done));
+	before(async () => {
+		await updateSetting('Livechat_accept_chats_with_no_agents', true);
+		await setUserActiveStatus('rocketchat.internal.admin.test', true);
+		await createAgent();
+		await makeAgentAvailable();
+	});
+	before(async () => {
+		const user: IUser = await createUser();
+		const userCredentials = await login(user.username, password);
+		if (!user.username) {
+			throw new Error('user not created');
+		}
+		await createManager(user.username);
+
+		manager = {
+			user,
+			credentials: userCredentials,
+		};
+	});
+	before(async () => {
+		const user: IUser = await createUser();
+		const userCredentials = await login(user.username, password);
+		if (!user.username) {
+			throw new Error('user not created');
+		}
+		await createMonitor(user.username);
+
+		monitor = {
+			user,
+			credentials: userCredentials,
+		};
+	});
+	before(async () => {
+		noUnitDepartment = await createDepartment();
+		unitDepartment = await createDepartment();
+
+		await createUnit(monitor.user._id, monitor.user.username!, [unitDepartment._id]);
+	});
+	before(async () => {
+		await updatePermission('transfer-livechat-guest', ['admin', 'livechat-manager', 'livechat-agent', 'livechat-monitor']);
+	});
+
+	describe('Monitors & Rooms', () => {
+		it('should not return a room of a department that the monitor is not assigned to', async () => {
+			const visitor = await createVisitor(noUnitDepartment._id);
+			const room = await createLivechatRoom(visitor.token);
+
+			const { body } = await request
+				.get(api('livechat/rooms'))
+				.set(monitor.credentials)
+				.expect('Content-Type', 'application/json')
+				.expect(200);
+
+			expect(body).to.have.property('rooms').that.is.an('array');
+			expect(body.rooms.find((r: any) => r._id === room._id)).to.not.exist;
+		});
+		it('should return a room of a department the monitor is assigned to', async () => {
+			const visitor = await createVisitor(unitDepartment._id);
+			const room = await createLivechatRoom(visitor.token);
+
+			const { body } = await request
+				.get(api('livechat/rooms'))
+				.set(monitor.credentials)
+				.expect('Content-Type', 'application/json')
+				.expect(200);
+
+			expect(body).to.have.property('rooms').that.is.an('array');
+			expect(body.rooms.find((r: any) => r._id === room._id)).to.exist;
+		});
+	});
+
+	describe('Monitors & Departments', () => {
+		it('should not return a department that the monitor is not assigned to', async () => {
+			const { body } = await request
+				.get(api('livechat/department'))
+				.query({ onlyMyDepartments: true })
+				.set(monitor.credentials)
+				.expect('Content-Type', 'application/json')
+				.expect(200);
+
+			expect(body).to.have.property('departments').that.is.an('array');
+			expect(body.departments.find((d: any) => d._id === noUnitDepartment._id)).to.not.exist;
+		});
+		it('should return a department that the monitor is assigned to', async () => {
+			const { body } = await request
+				.get(api('livechat/department'))
+				.query({ onlyMyDepartments: true })
+				.set(monitor.credentials)
+				.expect('Content-Type', 'application/json')
+				.expect(200);
+
+			expect(body).to.have.property('departments').that.is.an('array');
+			expect(body.departments.length).to.be.equal(1);
+			expect(body.departments.find((d: any) => d._id === unitDepartment._id)).to.exist;
+		});
+		it('should return both created departments to a manager', async () => {
+			const { body } = await request
+				.get(api('livechat/department'))
+				.query({ onlyMyDepartments: true, sort: '{ "_updatedAt": 1 }' })
+				.set(manager.credentials)
+				.expect('Content-Type', 'application/json')
+				.expect(200);
+
+			expect(body).to.have.property('departments').that.is.an('array');
+			expect(body.departments.find((d: any) => d._id === noUnitDepartment._id)).to.exist;
+			expect(body.departments.find((d: any) => d._id === unitDepartment._id)).to.exist;
+		});
+		it('should not return a department when monitor is only assigned as agent there', async () => {
+			await createAgent(monitor.user.username!);
+			await addOrRemoveAgentFromDepartment(
+				noUnitDepartment._id,
+				{ agentId: monitor.user._id, username: monitor.user.username!, count: 0, order: 0 },
+				true,
+			);
+
+			const { body } = await request
+				.get(api('livechat/department'))
+				.query({ onlyMyDepartments: true })
+				.set(monitor.credentials)
+				.expect('Content-Type', 'application/json')
+				.expect(200);
+
+			expect(body).to.have.property('departments').that.is.an('array');
+			expect(body.departments.length).to.be.equal(1);
+			expect(body.departments.find((d: any) => d._id === noUnitDepartment._id)).to.not.exist;
+		});
+	});
+
+	describe('Monitors & Forward', () => {
+		it('should successfully forward a room to another agent', async () => {
+			const visitor = await createVisitor(unitDepartment._id);
+			const room = await createLivechatRoom(visitor.token);
+
+			const { body } = await request
+				.post(api('livechat/room.forward'))
+				.set(monitor.credentials)
+				.send({
+					roomId: room._id,
+					userId: 'rocketchat.internal.admin.test',
+				})
+				.expect('Content-Type', 'application/json')
+				.expect(200);
+
+			expect(body).to.have.property('success', true);
+
+			const room2 = await getLivechatRoomInfo(room._id);
+
+			expect(room2).to.have.property('servedBy').that.is.an('object');
+			expect(room2.servedBy).to.have.property('_id', 'rocketchat.internal.admin.test');
+		});
+		it('should successfully forward a room to a department', async () => {
+			const visitor = await createVisitor(noUnitDepartment._id);
+			const room = await createLivechatRoom(visitor.token);
+
+			const { body } = await request
+				.post(api('livechat/room.forward'))
+				.set(monitor.credentials)
+				.send({
+					roomId: room._id,
+					departmentId: unitDepartment._id,
+				})
+				.expect('Content-Type', 'application/json')
+				.expect(200);
+
+			expect(body).to.have.property('success', true);
+
+			const room2 = await getLivechatRoomInfo(room._id);
+			expect(room2.departmentId).to.be.equal(unitDepartment._id);
+		});
+	});
+});