temp

RocketChat · Oct 15, 2024 · ce18557 · ce18557
1 parent 98552dd
commit ce18557
Show file tree

Hide file tree

Showing 9 changed files with 431 additions and 89 deletions.
diff --git a/packages/jest-presets/package.json b/packages/jest-presets/package.json
@@ -16,6 +16,7 @@
 		"@swc/core": "~1.7.26",
 		"@swc/jest": "~0.2.36",
 		"@testing-library/jest-dom": "~6.4.8",
+		"@testing-library/react": "~16.0.1",
 		"@types/jest-axe": "~3.5.9",
 		"identity-obj-proxy": "~3.0.0",
 		"jest-axe": "~9.0.0",

diff --git a/packages/jest-presets/src/client/jest-setup.ts b/packages/jest-presets/src/client/jest-setup.ts
@@ -1,12 +1,15 @@
 import { TextEncoder, TextDecoder } from 'node:util';
 
+import { configure } from '@testing-library/react';
 import { toHaveNoViolations } from 'jest-axe';
 import * as uuid from 'uuid';
 
 import '@testing-library/jest-dom';
 
 expect.extend(toHaveNoViolations);
 
+configure({ reactStrictMode: true });
+
 const urlByBlob = new WeakMap<Blob, string>();
 const blobByUrl = new Map<string, Blob>();
 

diff --git a/packages/ui-client/src/components/UserAutoComplete/UserAutoComplete.tsx b/packages/ui-client/src/components/UserAutoComplete/UserAutoComplete.tsx
@@ -17,8 +17,7 @@ type UserAutoCompleteProps = Omit<ComponentProps<typeof AutoComplete>, 'filter'>
 	conditions?: { [key: string]: unknown };
 };
 
-const UserAutoComplete = ({ value, onChange, ...props }: UserAutoCompleteProps): ReactElement => {
-	const { conditions = {} } = props;
+const UserAutoComplete = ({ conditions = {}, value, onChange, ...props }: UserAutoCompleteProps): ReactElement => {
 	const [filter, setFilter] = useState('');
 	const debouncedFilter = useDebouncedValue(filter, 1000);
 	const usersAutoCompleteEndpoint = useEndpoint('GET', '/v1/users.autocomplete');

diff --git a/packages/ui-client/src/helpers/anchors.ts b/packages/ui-client/src/helpers/anchors.ts
@@ -20,6 +20,9 @@ const setAnchorRefCount = (anchorElement: HTMLElement, refCount: number): void =
 
 export const refAnchorElement = (anchorElement: HTMLElement): void => {
 	setAnchorRefCount(anchorElement, getAnchorRefCount(anchorElement) + 1);
+	if (!anchorElement.parentElement) {
+		document.body.appendChild(anchorElement);
+	}
 };
 
 export const unrefAnchorElement = (anchorElement: HTMLElement): void => {

diff --git a/packages/ui-voip/src/components/VoipPopup/VoipPopup.spec.tsx b/packages/ui-voip/src/components/VoipPopup/VoipPopup.spec.tsx
@@ -21,30 +21,38 @@ const mockedUseVoipSession = jest.mocked(useVoipSession);
 const appRoot = mockAppRoot();
 
 it('should properly render incoming popup', async () => {
-	mockedUseVoipSession.mockImplementationOnce(() => createMockVoipSession({ type: 'INCOMING' }));
+	mockedUseVoipSession
+		.mockImplementationOnce(() => createMockVoipSession({ type: 'INCOMING' }))
+		.mockImplementationOnce(() => createMockVoipSession({ type: 'INCOMING' }));
 	render(<VoipPopup />, { wrapper: appRoot.build() });
 
 	expect(screen.getByTestId('vc-popup-incoming')).toBeInTheDocument();
 });
 
 it('should properly render ongoing popup', async () => {
-	mockedUseVoipSession.mockImplementationOnce(() => createMockVoipSession({ type: 'ONGOING' }));
+	mockedUseVoipSession
+		.mockImplementationOnce(() => createMockVoipSession({ type: 'ONGOING' }))
+		.mockImplementationOnce(() => createMockVoipSession({ type: 'ONGOING' }));
 
 	render(<VoipPopup />, { wrapper: appRoot.build() });
 
 	expect(screen.getByTestId('vc-popup-ongoing')).toBeInTheDocument();
 });
 
 it('should properly render outgoing popup', async () => {
-	mockedUseVoipSession.mockImplementationOnce(() => createMockVoipSession({ type: 'OUTGOING' }));
+	mockedUseVoipSession
+		.mockImplementationOnce(() => createMockVoipSession({ type: 'OUTGOING' }))
+		.mockImplementationOnce(() => createMockVoipSession({ type: 'OUTGOING' }));
 
 	render(<VoipPopup />, { wrapper: appRoot.build() });
 
 	expect(screen.getByTestId('vc-popup-outgoing')).toBeInTheDocument();
 });
 
 it('should properly render error popup', async () => {
-	mockedUseVoipSession.mockImplementationOnce(() => createMockVoipSession({ type: 'ERROR' }));
+	mockedUseVoipSession
+		.mockImplementationOnce(() => createMockVoipSession({ type: 'ERROR' }))
+		.mockImplementationOnce(() => createMockVoipSession({ type: 'ERROR' }));
 
 	render(<VoipPopup />, { wrapper: appRoot.build() });
 
@@ -58,7 +66,9 @@ it('should properly render dialer popup', async () => {
 });
 
 it('should prioritize session over dialer', async () => {
-	mockedUseVoipSession.mockImplementationOnce(() => createMockVoipSession({ type: 'INCOMING' }));
+	mockedUseVoipSession
+		.mockImplementationOnce(() => createMockVoipSession({ type: 'INCOMING' }))
+		.mockImplementationOnce(() => createMockVoipSession({ type: 'INCOMING' }));
 
 	render(<VoipPopup />, { wrapper: appRoot.build() });