member list is randomly sorted

[CvH]

Description:

The users at the memberlist are randomly sorted and it is difficult to find someone without actually using the search, /directory/users works properly in that regard.
The "sort by" setting is also ignored for it.

Steps to reproduce:

1. open the memberlist at the general channel

Expected behavior:

list the members in alphabetically

Actual behavior:

Server Setup Information:

• Version of Rocket.Chat Server: 3.15.0
• Operating System: Ubuntu
• Deployment Method: snap
• Number of Running Instances: 1
• DB Replicaset Oplog: -
• NodeJS Version: v12.22.1
• MongoDB Version: 3.6.14

Client Setup Information

• Desktop App or Browser Version: Chrome latest
• Operating System: Win/Linux

Additional context

Relevant logs:

[emikolajczak]

Hi, I confirm. It's hard to say what it is sorted by. Certainly not by Full name or Username

[ankar84]

Confirm that issue. Users complaining about that.

[johncrisp]

First thing is please upgrade immediately to 3.14.4

See the release notes for why.

Has anyone tested this on either 3.14.4 or 3.15?

[CvH]

@johncrisp currently running 3.15, still the same issue appears (updated issue description with new version)

[ghost]

on 3.16, sorting by name seems to be working. but sorting by activity is totally random

[ivanvsobolev-devops]

on 3.16, sorting by name seems to be working. but sorting by activity is totally random

on 3.17.1, still sorting by activity is random

[CvH]

still a problem at the latest official version currently available 3.18.1

[ankar84]

3.18.2 same issue

[CvH]

4.3.1 same issue

[ankar84]

@dudanogueira @debdutdeb please take a look at that issue.
It's not so critical in functionality aspect, it's a UI\UX bug, but very annoying to users.

[AmiKonst]

So. Where is the solution?

[CvH]

5.4 same issue

[WYGIN]

@dudanogueira assign this issue to me i will commit & will i need to sort members by name or username

[varun-s22]

@debdutdeb Hey there.. is this issue still open?
can i take it?

[kartikbh6614]

I want to work on this issue please assign me this issue

[Srishti-j18]

Hi, I want to work on this issue, can you please assign me this issue?

[Vip2799]

I would like to solve this issue. please assign me this issue

[Karan-Bhatta]

Hi there, I want to work to fix this issue. But this is what I am getting while cloning

[debdutdeb]

Anybody wanting to work on this, please go ahead; no need to assign to anybody. Thanks.

[debdutdeb]

Hi there, I want to work to fix this issue. But this is what I am getting while cloning

Is this wsl?

[Rishabhg71]

Hi there, I want to work to fix this issue. But this is what I am getting while cloning

you need to clone the repo inside WSL if on windows
it seems you are on git bash terminal

[dharmvir73]

I want to work on this issue please assign me this issue.

[Gua00va]

Hey!! I want to work on this issue. I'm new here so I'm really excited to start contributing.

[eshan-003]

Hey Please Assign this issue to me @debdutdeb . I want to work on this

[dudanogueira]

Folks, again, no need to assign. If you want to work on this, the path would be:
1 - Propose a good sorting
2 - Identify where the current code is
3 - Explain how you want to fix
4 - Code/Improve the PR
5 - Submit to review
6 - If not approved/merge, back to 4

Consider that it uses this api to grab the list of members:
https://developer.rocket.chat/reference/api/rest-api/endpoints/core-endpoints/channels-endpoints/members

Rocket.Chat/apps/meteor/app/api/server/v1/channels.js

Lines 503 to 536 in 7960ff9

	API.v1.addRoute(
	'channels.members',
	{ authRequired: true },
	{
	async get() {
	const findResult = findChannelByIdOrName({
	params: this.requestParams(),
	checkedArchived: false,
	});
	if (findResult.broadcast && !hasPermission(this.userId, 'view-broadcast-member-list', findResult._id)) {
	return API.v1.unauthorized();
	}
	const { offset: skip, count: limit } = this.getPaginationItems();
	const { sort = {} } = this.parseJsonQuery();
	check(
	this.queryParams,
	Match.ObjectIncluding({
	status: Match.Maybe([String]),
	filter: Match.Maybe(String),
	}),
	);
	const { status, filter } = this.queryParams;
	const { cursor, totalCount } = findUsersOfRoom({
	rid: findResult._id,
	...(status && { status: { $in: status } }),
	skip,
	limit,
	filter,
	...(sort?.username && { sort: { username: sort.username } }),
	});

[sujaltangde]

I would like to contribute on this issue please assign it to me

[CvH]

@sujaltangde
#22145 (comment)

Folks, again, no need to assign. If you want to work on this, the path would be: 1 - Propose a good sorting 2 - Identify where the current code is 3 - Explain how you want to fix 4 - Code/Improve the PR 5 - Submit to review 6 - If not approved/merge, back to 4

[zero-commit]

can somebody help me find where this code is lying

[divyanshu255]

hello,i think i can fix this .please, assign it to me.

[harshbsharma]

Would like to work on it. Please assign

[SHIVAM-lab]

I will fix this , assign this issue to me

[debdutdeb]

@sujaltangde #22145 (comment)

Folks, again, no need to assign. If you want to work on this, the path would be: 1 - Propose a good sorting 2 - Identify where the current code is 3 - Explain how you want to fix 4 - Code/Improve the PR 5 - Submit to review 6 - If not approved/merge, back to 4

Please read this 🙏🏼

[Jatingupta9120]

hey Is the issue still open i would like to work upon the issue please assign this issue to me.

[mahmoodshariff123]

hey is this issue still open?plz assign it to me if it is not closed

[Arihant25]

This issue seems fixed should it be closed now?

[SaraswatSahoo]

hey I have fixed this issue and made a pull request for it please review the PR #34141

[Curious-Goblin]

I think, in the latest version of Rocket chat the issue is fixed already.