Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: member list is randomly sorted #31891

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Arin13-03
Copy link

@Arin13-03 Arin13-03 commented Mar 4, 2024

Issue: ( #22145)
The current implementation of the channels.members endpoint does not provide members in alphabetical order, causing inconvenience to users who expect a sorted list. This issue makes it challenging for users to locate specific members without using the search functionality.

Changes Made:
In this pull request, I have addressed the sorting issue by modifying the channels.members endpoint to ensure that the member list is sorted alphabetically by username before being returned in the API response. This enhancement will provide users with a more organized and easily navigable member list within channels.

Testing:
I have thoroughly tested the changes to ensure their correctness and effectiveness:

  1. Created test cases to validate the sorting functionality, covering scenarios with different numbers of members and usernames with special characters.
  2. Conducted manual testing of the endpoint in various environments to verify consistent alphabetical sorting.
  3. Confirm that the member list is now presented in alphabetical order as expected.

Dependencies:
This pull request introduces no new dependencies. The sorting logic leverages the localeCompare() function to ensure accurate alphabetical sorting based on user usernames.

Additional Notes:
The proposed changes aim to enhance the user experience by providing a more intuitive and organized member list within channels. By sorting members alphabetically, we aim to streamline navigation and improve user satisfaction.

Copy link

changeset-bot bot commented Mar 4, 2024

⚠️ No Changeset found

Latest commit: df8f331

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CLAassistant
Copy link

CLAassistant commented Mar 4, 2024

CLA assistant check
All committers have signed the CLA.

@Arin13-03 Arin13-03 changed the title chore: member list is randomly sorted #22145 Solved chore: member list is randomly sorted #22145 Mar 4, 2024
@Arin13-03 Arin13-03 changed the title chore: member list is randomly sorted #22145 chore: member list is randomly sorted Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants