Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: EditRoomInfo to typescript #28318

Merged
merged 7 commits into from
Oct 13, 2023
Merged

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented Mar 7, 2023

Proposed changes (including videos or screenshots)

  • It also replaces useForm in favor of react-hook-form

Issue(s)

Steps to test or reproduce

Further comments

DSAR-68

@dougfabris dougfabris added this to the 6.1.0 milestone Mar 7, 2023
@dougfabris dougfabris modified the milestones: 6.1.0, 6.2.0 Mar 31, 2023
@dougfabris dougfabris modified the milestones: 6.2.0, 6.3.0 Apr 14, 2023
@dougfabris dougfabris changed the title Chore: Refactor EditRoomInfo to typescript refactor: EditRoomInfo to typescript Apr 27, 2023
@dougfabris dougfabris modified the milestones: 6.3.0, 6.4.0 Jun 16, 2023
@ggazzo ggazzo modified the milestones: 6.4.0, 6.5.0 Aug 31, 2023
@changeset-bot
Copy link

changeset-bot bot commented Oct 6, 2023

⚠️ No Changeset found

Latest commit: c044a7c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #28318 (c044a7c) into develop (dd254a9) will decrease coverage by 0.14%.
The diff coverage is 69.56%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #28318      +/-   ##
===========================================
- Coverage    51.28%   51.14%   -0.14%     
===========================================
  Files          811      805       -6     
  Lines        15074    15074              
  Branches      2752     2785      +33     
===========================================
- Hits          7731     7710      -21     
+ Misses        6935     6928       -7     
- Partials       408      436      +28     
Flag Coverage Δ
e2e 48.46% <69.56%> (-0.10%) ⬇️
unit 64.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dougfabris dougfabris marked this pull request as ready for review October 7, 2023 01:05
@dougfabris dougfabris requested a review from a team as a code owner October 7, 2023 01:05
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Oct 13, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Oct 13, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Oct 13, 2023
@kodiakhq kodiakhq bot merged commit ae71e31 into develop Oct 13, 2023
43 checks passed
@kodiakhq kodiakhq bot deleted the chore/refactor-editRoomInfo branch October 13, 2023 15:29
gabriellsh added a commit that referenced this pull request Oct 16, 2023
…/mentionBot

* 'develop' of github.com:RocketChat/Rocket.Chat:
  feat: add tooltip to badge mentions (#30590)
  chore: improve `Tag` a11y link (#30636)
  refactor: Replace `useForm` in favor of RHF on `AppInstallPage` (#30634)
  fix: Improve FileProxy Handling, set Content-Type (#30427)
  refactor: `EditRoomInfo` to typescript (#28318)
  fix: mobile ringing notification missing call id (#30614)
  fix: Some HTTP requests sent by apps don't have their data parsed into JSON (#30560)
  test: More tests for groups kick (#30536)
  fix: Threads breaking after sending messages too fast (#30622)
  chore: Remove text decoration from room tag (#30606)
  i18n: Language update from LingoHub 🤖 on 2023-10-10Z (#30613)
  fix: File attachments have no content when exporting room messages as file (#30596)
  fix: use setImmediate to handle username update (#30500)
  chore: `AnalyticsReports` visual adequacy (#30617)
debdutdeb pushed a commit that referenced this pull request Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants