-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(client): Move Meteor overrides #28366
Conversation
397fc66
to
599586c
Compare
refactor/client-startup
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #28366 +/- ##
===========================================
+ Coverage 49.52% 58.68% +9.16%
===========================================
Files 3314 1776 -1538
Lines 81448 34625 -46823
Branches 16670 7229 -9441
===========================================
- Hits 40339 20321 -20018
+ Misses 36397 12732 -23665
+ Partials 4712 1572 -3140
Flags with carried forward coverage won't be shown. Click here to find out more. |
7fc4517
to
aacd393
Compare
aacd393
to
306d2c6
Compare
|
e04ce3d
to
de780f0
Compare
de780f0
to
1ac5555
Compare
…ctor/client-startup
…RocketChat/Rocket.Chat into refactor/client-startup
Proposed changes (including videos or screenshots)
Overriden Meteor methods/functions are critical for the correct initialization of the client, therefore this PR moves the most to the beginning of a bunch of dynamic imports.
Issue(s)
Steps to test or reproduce
Further comments