Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(client): Move Meteor overrides #28366

Merged
merged 9 commits into from
Jan 9, 2024
Merged

Conversation

tassoevan
Copy link
Contributor

@tassoevan tassoevan commented Mar 10, 2023

Proposed changes (including videos or screenshots)

Overriden Meteor methods/functions are critical for the correct initialization of the client, therefore this PR moves the most to the beginning of a bunch of dynamic imports.

Issue(s)

Steps to test or reproduce

Further comments

@ggazzo ggazzo changed the title Chore: refactor/client-startup chore: refactor/client-startup Mar 10, 2023
@tassoevan tassoevan force-pushed the refactor/client-startup branch from 397fc66 to 599586c Compare March 10, 2023 21:10
@tassoevan tassoevan changed the title chore: refactor/client-startup refactor(client): Startup routines Mar 10, 2023
@codecov
Copy link

codecov bot commented Mar 10, 2023

Codecov Report

Attention: 156 lines in your changes are missing coverage. Please review.

Comparison is base (319f05e) 49.52% compared to head (15b3d46) 58.68%.
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #28366      +/-   ##
===========================================
+ Coverage    49.52%   58.68%   +9.16%     
===========================================
  Files         3314     1776    -1538     
  Lines        81448    34625   -46823     
  Branches     16670     7229    -9441     
===========================================
- Hits         40339    20321   -20018     
+ Misses       36397    12732   -23665     
+ Partials      4712     1572    -3140     
Flag Coverage Δ
e2e 51.57% <39.61%> (-1.50%) ⬇️
e2e-api ?
unit 76.68% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@tassoevan tassoevan force-pushed the refactor/client-startup branch 6 times, most recently from 7fc4517 to aacd393 Compare March 14, 2023 03:28
@tassoevan tassoevan force-pushed the refactor/client-startup branch from aacd393 to 306d2c6 Compare December 19, 2023 14:18
Copy link

changeset-bot bot commented Dec 19, 2023

⚠️ No Changeset found

Latest commit: 15b3d46

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tassoevan tassoevan force-pushed the refactor/client-startup branch 3 times, most recently from e04ce3d to de780f0 Compare December 21, 2023 14:44
@tassoevan tassoevan force-pushed the refactor/client-startup branch from de780f0 to 1ac5555 Compare December 22, 2023 18:47
@tassoevan tassoevan changed the title refactor(client): Startup routines refactor(client): Move Meteor overrides Dec 22, 2023
@tassoevan tassoevan marked this pull request as ready for review December 22, 2023 19:51
@tassoevan tassoevan requested review from a team as code owners December 22, 2023 19:51
@tassoevan tassoevan requested a review from a team as a code owner December 22, 2023 19:51
@tassoevan tassoevan added this to the 6.6 milestone Dec 22, 2023
@ggazzo ggazzo merged commit 1b486a1 into develop Jan 9, 2024
42 of 43 checks passed
@ggazzo ggazzo deleted the refactor/client-startup branch January 9, 2024 19:09
gabriellsh added a commit that referenced this pull request Jan 9, 2024
…ve/Notifications

* 'develop' of github.com:RocketChat/Rocket.Chat:
  refactor(client): Move Meteor overrides (#28366)
  fix: login buttons remain visible until refresh after disabling authentication service (#31371)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants