Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use apps-engine service to trigger events from server/methods #29557

Open
wants to merge 1 commit into
base: feat/apps-engine-services
Choose a base branch
from

Conversation

tapiarafael
Copy link
Member

@tapiarafael tapiarafael commented Jun 15, 2023

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

AECO-147

@tapiarafael tapiarafael requested a review from a team as a code owner June 15, 2023 20:45
@changeset-bot
Copy link

changeset-bot bot commented Jun 15, 2023

⚠️ No Changeset found

Latest commit: 59b70e5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.53%. Comparing base (c9a7a02) to head (59b70e5).
Report is 300 commits behind head on feat/apps-engine-services.

Additional details and impacted files

Impacted file tree graph

@@                      Coverage Diff                      @@
##           feat/apps-engine-services   #29557      +/-   ##
=============================================================
+ Coverage                      45.37%   46.53%   +1.15%     
=============================================================
  Files                            695      700       +5     
  Lines                          12914    13044     +130     
  Branches                        2230     2235       +5     
=============================================================
+ Hits                            5860     6070     +210     
+ Misses                          6741     6646      -95     
- Partials                         313      328      +15     
Flag Coverage Δ
e2e 46.50% <ø> (+1.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@tapiarafael tapiarafael changed the title refactor: use apps-engine service to trigger events refactor: use apps-engine service to trigger events from server/methods Jun 15, 2023
@d-gubert d-gubert added the feat: Apps-Engine MS Moving the Apps-Engine to Microservices label Jun 28, 2023
Copy link
Contributor

dionisio-bot bot commented Apr 12, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR has conflicts, please resolve them before merging
  • This PR is missing the 'stat: QA assured' label
  • This PR is not mergeable
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: Apps-Engine MS Moving the Apps-Engine to Microservices stat: conflict
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants