fix: in forward search field, user cannot be found by name (Full Name) #29663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 165f646 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Rottenblasters
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #29663 +/- ##
========================================
Coverage 50.93% 50.93%
========================================
Files 809 809
Lines 15016 15016
Branches 2724 2724
========================================
Hits 7649 7649
Misses 6958 6958
Partials 409 409
Flags with carried forward coverage won't be shown. Click here to find out more. |
Rottenblasters
changed the title
|
+1 |
yash-rajpal
approved these changes
Sep 22, 2023
dionisio-bot
bot
added
the
stat: ready to merge
dionisio-bot
bot
removed
the
stat: ready to merge
yash-rajpal
added
the
stat: ready to merge
dionisio-bot
bot
removed
the
stat: ready to merge
ggazzo
approved these changes
Oct 3, 2023
gabriellsh
added a commit
that referenced
this pull request
Oct 3, 2023
…e/translationCdn * 'develop' of github.com:RocketChat/Rocket.Chat: (117 commits) chore: do not focus messagebox on mobile devices (#30553) chore: add the new endpoints to sync with cloud (#30546) fix: in forward search field, user cannot be found by name (Full Name) (#29663) chore: set license public key v3 with v2 (#30548) chore: adjust callbacks return type (#30547) chore: Delete Trigger Endpoint (#30533) test: adding missing verifications on message-actions (#30531) refactor: Oembed backend (#30228) test: refactor API E2E tests for groups endpoints (#30523) test: adding missing verifications on threads (#30528) chore: refactor cloud sync (#30401) refactor: Omni logs (#30322) refactor: Livechat Header -> ts (#30255) chore: Deprecate un-used meteor method for omnichannel analytics (#30421) feat: add supported versions + minimum clients versions to the info endpoint (#30178) feat: Auto-enable autotranslate (#30370) chore: Prevent call license and registration status endpoints when not enough permission (#30336) ci: Security/GitHub jira integration (#29776) feat: License V3 (#30287) chore: move Omnichannel toolbox section from sidebar room list (#30502) ...
gabriellsh
added a commit
that referenced
this pull request
Oct 6, 2023
…t into improve/ui-caching * 'improve/ui-caching' of github.com:RocketChat/Rocket.Chat: (40 commits) Update .changeset/wicked-humans-hang.md feat: Save visitor's activity on agent's interaction (#30222) chore: update mentions upsell modal content (#30503) fix: font-disabled color (#30569) chore: anchor text-decoration rules (#30485) chore: `AccessibilityPage` hide Enterprise tag when is EE (#30486) chore: Replace `Field.[SUBCOMPONENT]` in favor of named imports (#30501) fix: Check for room scoped permissions for creating discussions (#30497) ci: fix Docker image build for production (#30562) chore: Fix triggers flaky tests (#30530) chore: get translations from CDN (#30331) feat: new `licenses.info` endpoint (#30473) ci: run tests from forks (#30556) regression: unmarked dangling promise on license validation (#30557) regression: fix initializing startup order (#30555) feat: push notification statistics (#30269) chore: do not focus messagebox on mobile devices (#30553) chore: add the new endpoints to sync with cloud (#30546) fix: in forward search field, user cannot be found by name (Full Name) (#29663) chore: set license public key v3 with v2 (#30548) ...
debdutdeb
pushed a commit
that referenced
this pull request
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Untitled.mp4
You can now search with both
usernameandfull name / namein share message search field.Previously the query to find users used only the
lowerCaseNamefield which used to store the lowercase version of the username. Now I have changed in to query either bylowerCaseNameorlowerCaseFName(which stores the lowercase version of the full name of the user)Issue(s)
Closes #29328
Closes #29632
Steps to test or reproduce
Further comments
SUP-327