Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move federation to the microservices architecture #29743

Draft
wants to merge 33 commits into
base: develop
Choose a base branch
from

Conversation

MarcosSpessatto
Copy link
Member

@MarcosSpessatto MarcosSpessatto commented Jul 6, 2023

FED-98
FED-99

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@changeset-bot
Copy link

changeset-bot bot commented Jul 6, 2023

⚠️ No Changeset found

Latest commit: 39ccd13

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 56.89%. Comparing base (08df231) to head (39ccd13).
Report is 337 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #29743      +/-   ##
===========================================
+ Coverage    49.55%   56.89%   +7.33%     
===========================================
  Files         3323     1734    -1589     
  Lines        81756    31543   -50213     
  Branches     16874     6729   -10145     
===========================================
- Hits         40517    17947   -22570     
+ Misses       36500    12129   -24371     
+ Partials      4739     1467    -3272     
Flag Coverage Δ
e2e 53.27% <50.00%> (+<0.01%) ⬆️
e2e-api ?
unit 69.89% <ø> (-6.59%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@MarcosSpessatto MarcosSpessatto marked this pull request as ready for review September 1, 2023 22:59
@MarcosSpessatto MarcosSpessatto requested review from a team as code owners September 1, 2023 22:59
@MarcosSpessatto MarcosSpessatto self-assigned this Sep 1, 2023
* chore? moving the CE code to the ee package

In this first step we are commenting all the dependencies out

* chore: merge EE code together

* chore: fix lint

* chore: fix lint

* fix: version

* fix: lint
* chore? moving the CE code to the ee package

In this first step we are commenting all the dependencies out

* chore: merge EE code together

* chore: fix lint

* chore: re-enable logger

* chore: re-enable i18n

* chore: remove directly dependency on notifications

* chore: enable settings

* chore: prefer events over callbacks

* chore: re enable messages, room and statistics deps from monolith using svc

* chore: re enable Federation class

* chore: remove todo

* chore: fix lint

* chore: fix lint

* chore: debug

* chore: updating eslint

* chore: remove debug flag

* fix: version

* fix: lint

* fix: build

* chore: federations tests to the new external pkg (#29926)

* chore: partially move federation unit tests to the new pkg

* chore: re enable more unit tests

* chore: fix lint

* chore: move e2e tests as well

* chore: fix lint

* ci: add federation service to ci build process (#29930)

* ci: add federation service to building process

* ci: fix arg name

* ci: add deps to Dockerfile

* ci: add missing dep

* ci: publish federation

* ci: missing dep
* chore? moving the CE code to the ee package

In this first step we are commenting all the dependencies out

* chore: merge EE code together

* chore: fix lint

* chore: re-enable logger

* chore: re-enable i18n

* chore: remove directly dependency on notifications

* chore: enable settings

* chore: prefer events over callbacks

* chore: re enable messages, room and statistics deps from monolith using svc

* chore: re enable Federation class

* chore: remove todo

* fix: wrong event name

* chore: remove internal federation code in favor of the new external pkg

* chore: fix lint

* chore: fix lint

* chore: fix lint

* chore: fix lint

* chore: debug

* chore: updating eslint

* chore: remove debug flag

* chore: add missing (inderect) dep

* chore: enable commented dep

* ci: missing deps on dockerfile

* ci: yet another missing dep

* chore: remove federation helper from federation pkg

* fix: prevent race condition on federation settings

* chore: do not enforce federation service

* fix: prevent calling fed svc if not enabled

* fix: move statistics back

* fix: version

* fix: lint

* fix: build

* chore: federations tests to the new external pkg (#29926)

* chore: partially move federation unit tests to the new pkg

* chore: re enable more unit tests

* chore: fix lint

* chore: move e2e tests as well

* chore: fix lint

* ci: add federation service to ci build process (#29930)

* ci: add federation service to building process

* ci: fix arg name

* ci: add deps to Dockerfile

* ci: add missing dep

* ci: publish federation

* ci: missing dep

* fix: small fix
@ggazzo ggazzo force-pushed the FED-94-Adapt-to-the-Microservices-Architecture branch from cd23f2b to 9c46152 Compare September 13, 2023 14:02
ggazzo
ggazzo previously approved these changes Sep 13, 2023
@ggazzo ggazzo added this to the 6.5.0 milestone Sep 13, 2023
@MarcosSpessatto MarcosSpessatto marked this pull request as draft September 19, 2023 14:02
@MarcosSpessatto
Copy link
Member Author

@ggazzo this depends on this fix to be fully functional.
#30446

@rodrigok rodrigok modified the milestones: 6.5.0, 6.6.0 Oct 17, 2023
@casalsgh casalsgh modified the milestones: 6.6, 6.7 Jan 23, 2024
@AliNunes AliNunes removed this from the 6.7 milestone Mar 6, 2024
Copy link
Contributor

dionisio-bot bot commented Apr 12, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR has conflicts, please resolve them before merging
  • This PR is missing the 'stat: QA assured' label
  • This PR is not mergeable
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants