Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Exporting rooms messages as file throws error on server side #29903

Closed
wants to merge 10 commits into from
Closed

fix: Exporting rooms messages as file throws error on server side #29903

Changes from 4 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c818176
Do not auto close read file stream
matheusbsilva137 Jul 24, 2023
7c5e0dd
Merge branch 'develop' of https://github.com/RocketChat/Rocket.Chat i…
matheusbsilva137 Jul 24, 2023
0b9bdc7
Merge branch 'develop' into fix/error-exporting-channel
debdutdeb Jul 25, 2023
ef98fbf
Merge branch 'develop' into fix/error-exporting-channel
matheusbsilva137 Aug 16, 2023
cc3c527
Merge branch 'develop' of https://github.com/RocketChat/Rocket.Chat i…
matheusbsilva137 Aug 29, 2023
022dbab
Merge branch 'develop' of https://github.com/RocketChat/Rocket.Chat i…
matheusbsilva137 Oct 11, 2023
d96ecf2
Do not create read stream via fd
matheusbsilva137 Oct 11, 2023
1a22b31
Create changesets
matheusbsilva137 Oct 11, 2023
ac0b9f9
Merge branch 'develop' into fix/error-exporting-channel
matheusbsilva137 Oct 11, 2023
991dc0b
Merge branch 'develop' into fix/error-exporting-channel
matheusbsilva137 Oct 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion apps/meteor/server/ufs/ufs-methods.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ export async function ufsComplete(fileId: string, storeName: string): Promise<IU
const rs = fs.createReadStream(tmpFile, {
flags: 'r',
encoding: undefined,
autoClose: true,
autoClose: false,
});

// Clean upload if error occurs
Expand All @@ -58,6 +58,7 @@ export async function ufsComplete(fileId: string, storeName: string): Promise<IU
// Save file in the store
await store.write(rs, fileId, (err, file) => {
removeTempFile();
rs.close();

if (err) {
return reject(err);
Expand Down