Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing params on updateOwnBasicInfo endpoint #30156

Merged
merged 4 commits into from
Sep 12, 2023

Conversation

dougfabris
Copy link
Member

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@changeset-bot
Copy link

changeset-bot bot commented Aug 23, 2023

🦋 Changeset detected

Latest commit: 988a52d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 29 packages
Name Type
@rocket.chat/rest-typings Minor
@rocket.chat/meteor Minor
@rocket.chat/core-services Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/ddp-client Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Major
@rocket.chat/livechat Patch
@rocket.chat/core-typings Minor
@rocket.chat/cron Patch
@rocket.chat/model-typings Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/models Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dougfabris dougfabris changed the title fix: missing params on updateOwnBasicInfo endpoint fix(meteor): missing params on updateOwnBasicInfo endpoint Aug 23, 2023
@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #30156 (988a52d) into develop (ee3815f) will decrease coverage by 0.06%.
Report is 17 commits behind head on develop.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #30156      +/-   ##
===========================================
- Coverage    50.00%   49.94%   -0.06%     
===========================================
  Files          782      781       -1     
  Lines        14521    14520       -1     
  Branches      2623     2634      +11     
===========================================
- Hits          7261     7252       -9     
- Misses        6850     6855       +5     
- Partials       410      413       +3     
Flag Coverage Δ
e2e 48.34% <ø> (-0.07%) ⬇️
unit 60.12% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@dougfabris dougfabris force-pushed the fix/updateOwnBasicInfo branch from 9802b2f to dc6fdba Compare September 8, 2023 17:57
@dougfabris dougfabris marked this pull request as ready for review September 11, 2023 13:48
@dougfabris dougfabris requested review from a team as code owners September 11, 2023 13:48
Copy link
Member

@matheusbsilva137 matheusbsilva137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I guess we're just missing changesets

@dougfabris
Copy link
Member Author

LGTM, I guess we're just missing changesets

oops, thanks for pointing it out dude

@dougfabris dougfabris changed the title fix(meteor): missing params on updateOwnBasicInfo endpoint fix: missing params on updateOwnBasicInfo endpoint Sep 11, 2023
@ggazzo ggazzo merged commit 93d4912 into develop Sep 12, 2023
41 checks passed
@ggazzo ggazzo deleted the fix/updateOwnBasicInfo branch September 12, 2023 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants