Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: User information crashing for some locales #30167

Merged
merged 3 commits into from
Aug 25, 2023
Merged

Conversation

tassoevan
Copy link
Contributor

@tassoevan tassoevan commented Aug 24, 2023

Proposed changes (including videos or screenshots)

Issue(s)

Closes #30001
Closes #30058
Closes #30097

Steps to test or reproduce

Further comments

@changeset-bot
Copy link

changeset-bot bot commented Aug 24, 2023

🦋 Changeset detected

Latest commit: 3ec32f0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 29 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/models Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tassoevan tassoevan added this to the 6.4.0 milestone Aug 24, 2023
@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #30167 (3ec32f0) into develop (3bf43bf) will increase coverage by 7.42%.
Report is 1 commits behind head on develop.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #30167      +/-   ##
===========================================
+ Coverage    40.73%   48.16%   +7.42%     
===========================================
  Files          649      693      +44     
  Lines        12450    13023     +573     
  Branches      2229     2300      +71     
===========================================
+ Hits          5072     6273    +1201     
+ Misses        7079     6399     -680     
- Partials       299      351      +52     
Flag Coverage Δ
e2e 48.13% <100.00%> (+7.40%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@tassoevan tassoevan marked this pull request as ready for review August 24, 2023 18:10
@tassoevan tassoevan requested a review from a team as a code owner August 24, 2023 18:10
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Aug 25, 2023
@ggazzo ggazzo changed the title fix: User information crashing for some locales fix: User information crashing for some locales Aug 25, 2023
@ggazzo ggazzo merged commit b59fd5d into develop Aug 25, 2023
@ggazzo ggazzo deleted the fix/use-time-ago branch August 25, 2023 03:32
@MartinSchoeler MartinSchoeler mentioned this pull request Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
2 participants