Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move team mentions to ce #30175

Merged
merged 14 commits into from
Sep 11, 2023
Merged

chore: move team mentions to ce #30175

merged 14 commits into from
Sep 11, 2023

Conversation

heitortanoue
Copy link
Contributor

Proposed changes (including videos or screenshots)

Move the Team Mentions feature to the RC Community Edition

Issue(s)

Steps to test or reproduce

Without the EE license, try to use the team mention feature by sending a message with @team, all team members should be notified.

Further comments

TC-901

@changeset-bot
Copy link

changeset-bot bot commented Aug 25, 2023

⚠️ No Changeset found

Latest commit: 7447923

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Merging #30175 (7447923) into develop (bb3a0d4) will decrease coverage by 0.38%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #30175      +/-   ##
===========================================
- Coverage    50.15%   49.77%   -0.38%     
===========================================
  Files          781      781              
  Lines        14520    14520              
  Branches      2627     2623       -4     
===========================================
- Hits          7282     7227      -55     
- Misses        6840     6885      +45     
- Partials       398      408      +10     
Flag Coverage Δ
e2e 48.15% <ø> (-0.43%) ⬇️
unit 60.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@heitortanoue heitortanoue marked this pull request as ready for review August 25, 2023 20:20
@heitortanoue heitortanoue requested a review from a team as a code owner August 25, 2023 20:20
yash-rajpal
yash-rajpal previously approved these changes Aug 28, 2023
Copy link
Member

@yash-rajpal yash-rajpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

apps/meteor/app/mentions/server/server.ts Outdated Show resolved Hide resolved
apps/meteor/app/mentions/server/getMentionedTeamMembers.ts Outdated Show resolved Hide resolved
apps/meteor/app/mentions/server/getMentionedTeamMembers.ts Outdated Show resolved Hide resolved
Copy link
Member

@matheusbsilva137 matheusbsilva137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we should also remove 'teams-mention' from BundleFeature and from the enterprise bundle (in bundles.ts), shouldn't we? 🤔

@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Sep 4, 2023
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Sep 5, 2023
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Sep 8, 2023
@scuciatto scuciatto added this to the 6.5.0 milestone Sep 11, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Sep 11, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Sep 11, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Sep 11, 2023
@heitortanoue heitortanoue dismissed KevLehman’s stale review September 11, 2023 20:44

changes already made

@heitortanoue heitortanoue removed the request for review from KevLehman September 11, 2023 20:45
@kodiakhq kodiakhq bot merged commit 258e9b3 into develop Sep 11, 2023
@kodiakhq kodiakhq bot deleted the chore/team-mentions-ce branch September 11, 2023 21:57
@scuciatto scuciatto modified the milestones: 6.5.0, 6.6.0 Oct 4, 2023
@scuciatto scuciatto modified the milestones: 6.6.0, 6.5.0 Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
squad: team-collab stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants