-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: move team mentions to ce #30175
Conversation
|
Codecov Report
@@ Coverage Diff @@
## develop #30175 +/- ##
===========================================
- Coverage 50.15% 49.77% -0.38%
===========================================
Files 781 781
Lines 14520 14520
Branches 2627 2623 -4
===========================================
- Hits 7282 7227 -55
- Misses 6840 6885 +45
- Partials 398 408 +10
Flags with carried forward coverage won't be shown. Click here to find out more. |
…nto chore/team-mentions-ce
…t/Rocket.Chat into chore/team-mentions-ce
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…t/Rocket.Chat into chore/team-mentions-ce
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we should also remove 'teams-mention'
from BundleFeature
and from the enterprise bundle (in bundles.ts
), shouldn't we? 🤔
Proposed changes (including videos or screenshots)
Move the Team Mentions feature to the RC Community Edition
Issue(s)
Steps to test or reproduce
Without the EE license, try to use the team mention feature by sending a message with
@team
, all team members should be notified.Further comments
TC-901