Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add supported versions + minimum clients versions to the info endpoint #30178

Merged
merged 20 commits into from
Sep 29, 2023
Merged

feat: add supported versions + minimum clients versions to the info endpoint #30178

merged 20 commits into from
Sep 29, 2023

Conversation

MarcosSpessatto
Copy link
Member

@MarcosSpessatto MarcosSpessatto commented Aug 25, 2023 •
edited
Loading

Proposed changes (including videos or screenshots)

Jira: NBJ-252

Issue(s)

Steps to test or reproduce

Further comments

@changeset-bot
Copy link

changeset-bot bot commented Aug 25, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: a1baa70

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MarcosSpessatto MarcosSpessatto changed the title feat: add new properties to the info endpoint feat: add supported versions + minimum clients versions to the info endpoint Aug 25, 2023
@codecov
Copy link

codecov bot commented Aug 25, 2023 •
edited
Loading

Codecov Report

Merging #30178 (a1baa70) into develop (f3118c7) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #30178      +/-   ##
===========================================
- Coverage    50.91%   50.85%   -0.06%     
===========================================
  Files          809      803       -6     
  Lines        15004    14985      -19     
  Branches      2722     2718       -4     
===========================================
- Hits          7639     7621      -18     
+ Misses        6956     6945      -11     
- Partials       409      419      +10
Flag Coverage Δ
e2e 48.55% <ø> (-0.04%) ⬇️
unit 62.77% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo force-pushed the NBJ-281-DEV-NBJ-LTS-Restrictions branch 7 times, most recently from ee8cfb9 to 53b5ec6 Compare September 19, 2023 18:14
@ggazzo ggazzo marked this pull request as ready for review September 19, 2023 23:16
@ggazzo ggazzo requested review from a team as code owners September 19, 2023 23:16
ggazzo
ggazzo previously approved these changes Sep 19, 2023
View reviewed changes
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Sep 19, 2023
@ggazzo ggazzo force-pushed the NBJ-281-DEV-NBJ-LTS-Restrictions branch from 53b5ec6 to 39b893a Compare September 19, 2023 23:24
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Sep 19, 2023
@ggazzo ggazzo force-pushed the NBJ-281-DEV-NBJ-LTS-Restrictions branch from 39b893a to cd263c3 Compare September 28, 2023 22:24
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Sep 28, 2023
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Sep 29, 2023
@ggazzo ggazzo force-pushed the NBJ-281-DEV-NBJ-LTS-Restrictions branch from 0cac727 to b986d63 Compare September 29, 2023 00:57
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Sep 29, 2023
@ggazzo ggazzo force-pushed the NBJ-281-DEV-NBJ-LTS-Restrictions branch from b986d63 to a786651 Compare September 29, 2023 01:06
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Sep 29, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Sep 29, 2023
ggazzo
ggazzo previously approved these changes Sep 29, 2023
View reviewed changes
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Sep 29, 2023
@ggazzo ggazzo force-pushed the NBJ-281-DEV-NBJ-LTS-Restrictions branch from 9b37be1 to dc1f07e Compare September 29, 2023 02:27
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Sep 29, 2023
@ggazzo ggazzo force-pushed the NBJ-281-DEV-NBJ-LTS-Restrictions branch from dc1f07e to a1baa70 Compare September 29, 2023 02:45
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Sep 29, 2023
@ggazzo ggazzo merged commit 59f581d into develop Sep 29, 2023
43 checks passed
@ggazzo ggazzo deleted the NBJ-281-DEV-NBJ-LTS-Restrictions branch September 29, 2023 05:04
gabriellsh added a commit that referenced this pull request Oct 3, 2023
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into chor…
006abf3 
…e/translationCdn

* 'develop' of github.com:RocketChat/Rocket.Chat: (117 commits)
  chore: do not focus messagebox on mobile devices (#30553)
  chore: add the new endpoints to sync with cloud (#30546)
  fix: in forward search field, user cannot be found by name (Full Name) (#29663)
  chore: set license public key v3 with v2 (#30548)
  chore: adjust callbacks return type (#30547)
  chore: Delete Trigger Endpoint (#30533)
  test: adding missing verifications on message-actions (#30531)
  refactor: Oembed backend (#30228)
  test: refactor API E2E tests for groups endpoints (#30523)
  test: adding missing verifications on threads (#30528)
  chore: refactor cloud sync (#30401)
  refactor: Omni logs (#30322)
  refactor: Livechat Header -> ts (#30255)
  chore: Deprecate un-used meteor method for omnichannel analytics (#30421)
  feat: add supported versions + minimum clients versions to the info endpoint (#30178)
  feat: Auto-enable autotranslate (#30370)
  chore: Prevent call license and registration status endpoints when not enough permission (#30336)
  ci: Security/GitHub jira integration (#29776)
  feat: License V3 (#30287)
  chore: move Omnichannel toolbox section from sidebar room list (#30502)
  ...
debdutdeb pushed a commit that referenced this pull request Oct 26, 2023
@MarcosSpessatto @debdutdeb
feat: add supported versions + minimum clients versions to the info e…
88e8cc1 
…ndpoint (#30178)
@pierre-lehnen-rc pierre-lehnen-rc mentioned this pull request Nov 4, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geekgonecrazy geekgonecrazy geekgonecrazy left review comments

@ggazzo ggazzo ggazzo approved these changes

Assignees
No one assigned
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarcosSpessatto @geekgonecrazy @ggazzo