refactor: unused code #33869
refactor: unused code #33869
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #33869 +/- ##
========================================
Coverage 75.42% 75.42%
========================================
Files 493 493
Lines 21499 21494 -5
Branches 5337 5336 -1
========================================
- Hits 16215 16212 -3
+ Misses 4644 4642 -2
Partials 640 640
Flags with carried forward coverage won't be shown. Click here to find out more. |
tassoevan
force-pushed
the
refactor/unused-code
branch
2 times, most recently
from
15c3b8d to
9bda431
Compare
tassoevan
force-pushed
the
refactor/unused-code
branch
from
9bda431 to
ed00c95
Compare
| @@ -1,204 +0,0 @@ | |||
| import { serverFetch as fetch } from '@rocket.chat/server-fetch'; | |||
| @@ -1,21 +0,0 @@ | |||
| import type { IMessage, IReport, RocketChatRecordDeleted } from '@rocket.chat/core-typings'; | |||
There was a problem hiding this comment.
Model was replaced by a new one in #28962, it's alright to remove this one now.
| @@ -1,21 +0,0 @@ | |||
| import { settings } from '../../../../../app/settings/server'; | |||
There was a problem hiding this comment.
File introduced by #23392, never got imported on the first place.
However, it was forgotten by mistake and is supposed to be imported instead of removed.
| @@ -9,17 +9,6 @@ import { useRoom, useRoomSubscription } from '../../contexts/RoomContext'; | |||
| import { useRoomToolbox } from '../../contexts/RoomToolboxContext'; | |||
| import NotificationPreferences from './NotificationPreferences'; | |||
|
|
|||
| export type NotificationFormValues = { | |||
There was a problem hiding this comment.
Stopped being used on #29113, ok to remove.
| @@ -1,52 +0,0 @@ | |||
| import type { ILivechatAgent, ILivechatDepartment } from '@rocket.chat/core-typings'; | |||
There was a problem hiding this comment.
Usage removed by #29594, ok to remove.
| @@ -112,16 +112,7 @@ export type PartialThis = { | |||
| readonly logger: Logger; | |||
| }; | |||
|
|
|||
| export type UserInfo = IUser & { | |||
There was a problem hiding this comment.
Hadn't been used since before this file was created, ok to remove.
| @@ -85,17 +85,6 @@ export async function getWorkspaceAccessTokenOrThrow(forceNew = false, scope = ' | |||
| return token; | |||
| } | |||
|
|
|||
| export const generateWorkspaceBearerHttpHeaderOrThrow = async ( | |||
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments