-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement users page active tab #30242
Conversation
Implemented the necessary resources to filter the list of users and to return only those who are active, when the active tab is enabled.
|
Codecov Report
@@ Coverage Diff @@
## feat/user-panel #30242 +/- ##
===================================================
- Coverage 50.02% 48.35% -1.67%
===================================================
Files 774 740 -34
Lines 14455 14100 -355
Branches 2613 2543 -70
===================================================
- Hits 7231 6818 -413
- Misses 6820 6904 +84
+ Partials 404 378 -26
Flags with carried forward coverage won't be shown. Click here to find out more. |
Implemented a new filter on the users' page that retrieves the roles list and creates a dropdown menu. When any of its options is selected, it will filter the users' list to display only those with the selected roles. Additionally, I made some minor adjustments to the MultiSelectCustom component and introduced some new hooks.
Completed the implementation of the users table actions menu by preventing the propagation of the click event that triggered the opening of the contextual bar when the menu was clicked. Also, ensured that the contextual bar only opens when the "Enter" or "Space" keys are used for keyboard navigation and enhanced the options menu in the contextual bar as specified in Figma.
Removed the status from the users page contextual bar (the need to remove this may not be concrete, for now it will be only commented until the final decision is made). Also changed the order of the contextual bar info and changed some minor styles to follow figma specs.
Proposed changes (including videos or screenshots)
Jira task: WM-86
Implemented the active users tab for the new users page tab layout. This page:
Also reorganized the contextual bar to follow figma specs and refactored both the table and contextual bar menus to also follow figma specs;
Demo gif:
Issue(s)
Steps to test or reproduce
Further comments