Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement users page active tab #30242

Merged
merged 12 commits into from
Oct 4, 2023
Merged

Conversation

rique223
Copy link
Contributor

@rique223 rique223 commented Aug 31, 2023

Proposed changes (including videos or screenshots)

Jira task: WM-86

Implemented the active users tab for the new users page tab layout. This page:

  • Displays only active users;
  • Displays only the Name, Username, Email, Roles and 'Actions' table columns;
  • Has a kebab menu in the right of each column row that has the same options as the contextual bar menu;

Also reorganized the contextual bar to follow figma specs and refactored both the table and contextual bar menus to also follow figma specs;

Demo gif:
users_page_active

Issue(s)

Steps to test or reproduce

Further comments

Implemented the necessary resources to filter the list of users and to return only those who are active, when the active tab is enabled.
@changeset-bot
Copy link

changeset-bot bot commented Aug 31, 2023

⚠️ No Changeset found

Latest commit: e2c3dbe

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@rique223 rique223 changed the base branch from develop to feat/user-panel August 31, 2023 19:57
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #30242 (e2c3dbe) into feat/user-panel (61681ff) will decrease coverage by 1.67%.
The diff coverage is 0.00%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           feat/user-panel   #30242      +/-   ##
===================================================
- Coverage            50.02%   48.35%   -1.67%     
===================================================
  Files                  774      740      -34     
  Lines                14455    14100     -355     
  Branches              2613     2543      -70     
===================================================
- Hits                  7231     6818     -413     
- Misses                6820     6904      +84     
+ Partials               404      378      -26     
Flag Coverage Δ
e2e 46.48% <ø> (-1.89%) ⬇️
unit 60.80% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Implemented a new filter on the users' page that retrieves the roles list and creates a dropdown menu. When any of its options is selected, it will filter the users' list to display only those with the selected roles. Additionally, I made some minor adjustments to the MultiSelectCustom component and introduced some new hooks.
Completed the implementation of the users table actions menu by preventing the propagation of the click event that triggered the opening of the contextual bar when the menu was clicked. Also, ensured that the contextual bar only opens when the "Enter" or "Space" keys are used for keyboard navigation and enhanced the options menu in the contextual bar as specified in Figma.
Removed the status from the users page contextual bar (the need to remove this may not be concrete, for now it will be only commented until the final decision is made). Also changed the order of the contextual bar info and changed some minor styles to follow figma specs.
@rique223 rique223 marked this pull request as ready for review September 28, 2023 16:49
@rique223 rique223 requested a review from a team as a code owner September 28, 2023 16:49
@rique223 rique223 changed the title feat: Implement active tab in new users page feat: Implement users page active tab Sep 29, 2023
@rique223 rique223 merged commit 90da483 into feat/user-panel Oct 4, 2023
40 of 41 checks passed
@rique223 rique223 deleted the feat/active-tab branch October 4, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants