-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Disable and annonimize visitors instead of removing and stats #30245
feat: Disable and annonimize visitors instead of removing and stats #30245
Conversation
🦋 Changeset detectedLatest commit: 452a7d4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 29 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## new/nbj-add-visitor-activity #30245 +/- ##
================================================================
+ Coverage 49.96% 50.12% +0.15%
================================================================
Files 774 774
Lines 14456 14456
Branches 2613 2613
================================================================
+ Hits 7223 7246 +23
+ Misses 6828 6807 -21
+ Partials 405 403 -2
Flags with carried forward coverage won't be shown. Click here to find out more. |
7af80bb
to
eeba96f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KevLehman what about the other LivechatVisitors
methods?
I saw you created some methods to retrieve only the enabled visitors. I assume if you didn't put the enabled filter there as well it's because they don't need it. But I'm concerned because there are a lot of places all over the code using those methods.
NBJ-317
NBJ-318
NBJ-319
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments