Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Disable and annonimize visitors instead of removing and stats #30245

Merged
merged 8 commits into from
Oct 4, 2023

Conversation

KevLehman
Copy link
Contributor

@KevLehman KevLehman commented Aug 31, 2023

NBJ-317
NBJ-318
NBJ-319

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@changeset-bot
Copy link

changeset-bot bot commented Aug 31, 2023

🦋 Changeset detected

Latest commit: 452a7d4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 29 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/model-typings Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/rest-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/ddp-client Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@KevLehman KevLehman changed the title Disable and annonimize visitor instead of removing feat: Disable and annonimize visitor instead of removing Aug 31, 2023
@KevLehman KevLehman changed the title feat: Disable and annonimize visitor instead of removing feat: Disable and annonimize visitors instead of removing Aug 31, 2023
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #30245 (fa783fb) into new/nbj-add-visitor-activity (889c3cf) will increase coverage by 0.15%.
The diff coverage is n/a.

❗ Current head fa783fb differs from pull request most recent head 452a7d4. Consider uploading reports for the commit 452a7d4 to get more accurate results

Impacted file tree graph

@@                       Coverage Diff                        @@
##           new/nbj-add-visitor-activity   #30245      +/-   ##
================================================================
+ Coverage                         49.96%   50.12%   +0.15%     
================================================================
  Files                               774      774              
  Lines                             14456    14456              
  Branches                           2613     2613              
================================================================
+ Hits                               7223     7246      +23     
+ Misses                             6828     6807      -21     
+ Partials                            405      403       -2     
Flag Coverage Δ
e2e 48.47% <ø> (+0.17%) ⬆️
unit 60.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@KevLehman KevLehman force-pushed the new/nbj-visitor-disabling branch from 7af80bb to eeba96f Compare September 20, 2023 19:07
Copy link
Member

@MarcosSpessatto MarcosSpessatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KevLehman what about the other LivechatVisitors methods?

I saw you created some methods to retrieve only the enabled visitors. I assume if you didn't put the enabled filter there as well it's because they don't need it. But I'm concerned because there are a lot of places all over the code using those methods.

apps/meteor/server/models/raw/LivechatVisitors.ts Outdated Show resolved Hide resolved
apps/meteor/app/livechat/server/lib/Livechat.js Outdated Show resolved Hide resolved
@KevLehman KevLehman added this to the 6.5.0 milestone Oct 3, 2023
@ggazzo ggazzo marked this pull request as ready for review October 4, 2023 00:33
@ggazzo ggazzo requested review from a team as code owners October 4, 2023 00:33
@ggazzo ggazzo requested a review from a team as a code owner October 4, 2023 00:43
@ggazzo ggazzo changed the title feat: Disable and annonimize visitors instead of removing feat: Disable and annonimize visitors instead of removing and stats Oct 4, 2023
@ggazzo ggazzo merged commit 59e1d81 into new/nbj-add-visitor-activity Oct 4, 2023
6 of 7 checks passed
@ggazzo ggazzo deleted the new/nbj-visitor-disabling branch October 4, 2023 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants