Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: password policies #30270

Merged
merged 25 commits into from
Sep 14, 2023
Merged

refactor: password policies #30270

merged 25 commits into from
Sep 14, 2023

Conversation

felipe-rod123
Copy link
Contributor

Proposed changes (including videos or screenshots)

Integrate backend and frontend password policies.

Issue(s)

Steps to test or reproduce

Further comments

WM-133

@changeset-bot
Copy link

changeset-bot bot commented Sep 4, 2023

⚠️ No Changeset found

Latest commit: d282875

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #30270 (d282875) into develop (7137a19) will decrease coverage by 0.07%.
The diff coverage is 83.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #30270      +/-   ##
===========================================
- Coverage    50.17%   50.10%   -0.07%     
===========================================
  Files          781      775       -6     
  Lines        14514    14484      -30     
  Branches      2623     2616       -7     
===========================================
- Hits          7282     7257      -25     
+ Misses        6835     6817      -18     
- Partials       397      410      +13     
Flag Coverage Δ
e2e 48.49% <ø> (-0.10%) ⬇️
unit 60.30% <83.33%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@hugocostadev hugocostadev marked this pull request as ready for review September 8, 2023 16:56
@hugocostadev hugocostadev requested review from a team as code owners September 8, 2023 16:56
@hugocostadev hugocostadev added this to the 6.5.0 milestone Sep 8, 2023
@hugocostadev hugocostadev added the squad: Workspace Management squad: Workspace Management label Sep 8, 2023
packages/password-policies/src/index.ts Outdated Show resolved Hide resolved
packages/password-policies/src/PasswordPolicyClass.ts Outdated Show resolved Hide resolved
packages/password-policies/src/PasswordPolicyClass.ts Outdated Show resolved Hide resolved
packages/password-policies/src/PasswordPolicyClass.ts Outdated Show resolved Hide resolved
packages/password-policies/src/PasswordPolicyClass.ts Outdated Show resolved Hide resolved
apps/meteor/app/lib/server/lib/passwordPolicy.ts Outdated Show resolved Hide resolved
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Sep 13, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Sep 13, 2023
@kodiakhq kodiakhq bot merged commit 92f5a02 into develop Sep 14, 2023
@kodiakhq kodiakhq bot deleted the chore/password-policies-new branch September 14, 2023 12:48
MartinSchoeler pushed a commit that referenced this pull request Sep 26, 2023
Co-authored-by: Hugo Costa <[email protected]>
Co-authored-by: Marcos Spessatto Defendi <[email protected]>
debdutdeb pushed a commit that referenced this pull request Oct 26, 2023
Co-authored-by: Hugo Costa <[email protected]>
Co-authored-by: Marcos Spessatto Defendi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
squad: Workspace Management squad: Workspace Management stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants