refactor: Implement functional code for the 'useFilteredApps' hook #30279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lementation Replaced the iterative implementation of the useFilteredApps hook with a functional one using underscores.js's compose function.
|
Codecov Report
@@ Coverage Diff @@
## develop #30279 +/- ##
===========================================
- Coverage 50.18% 50.10% -0.09%
===========================================
Files 781 775 -6
Lines 14507 14484 -23
Branches 2621 2616 -5
===========================================
- Hits 7281 7257 -24
+ Misses 6829 6813 -16
- Partials 397 414 +17
Flags with carried forward coverage won't be shown. Click here to find out more. |
tiagoevanp
requested changes
Sep 11, 2023
tiagoevanp
approved these changes
Sep 14, 2023
dionisio-bot
bot
added
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
gabriellsh
added a commit
that referenced
this pull request
Sep 19, 2023
…ove/iframeLogin * 'develop' of github.com:RocketChat/Rocket.Chat: (29 commits) fix: Disables `GenericMenu` without any sections or items (#30319) i18n: Language update from LingoHub 🤖 on 2023-09-18Z (#30426) chore: remove connectToCloud option (#30430) chore: remove Troubleshoot options (#30429) chore: bump fuselage packages (#30424) chore: Webhooks page refactor (#30274) chore: color palette changes (#30385) fix: increase cron job check delay to 1 min (#30402) fix: Presence broadcast isn't enabled after license validation (#30282) test: create non private team and readonly team (#30371) Bump version to 6.5.0-develop refactor: Implement functional code for the 'useFilteredApps' hook (#30279) Release 6.4.0-rc.1 Release 6.3.6 regression: Login page callout messages (#30399) test: tests for muting and unmuting (#30286) regression: Fix rooms table not showing teams (#30361) regression: Move queue-timeout setting to CE and remove dependency on waiting queue (#30386) fix: engagement dashboard not working (#30277) Bump 6.3.6 ...
MartinSchoeler
pushed a commit
that referenced
this pull request
Sep 26, 2023
…30279) Co-authored-by: Tiago Evangelista Pinto <[email protected]>
debdutdeb
pushed a commit
that referenced
this pull request
Oct 26, 2023
…30279) Co-authored-by: Tiago Evangelista Pinto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Replaced the iterative implementation of the 'useFilteredApps' hook with a functional one using a homebrew function composition method implementation.
Issue(s)
Steps to test or reproduce
Further comments