-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Presence broadcast isn't enabled after license validation #30282
Merged
sampaiodiego
merged 16 commits into
develop
from
fix/presence-broadcast-not-enabled-license
Sep 18, 2023
Merged
Changes from 6 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
ef1ff6f
Enable presence broadcast after validating the license
matheusbsilva137 863524f
Create changesets
matheusbsilva137 72fff5b
Merge branch 'develop' into fix/presence-broadcast-not-enabled-license
matheusbsilva137 6357b62
Merge branch 'develop' into fix/presence-broadcast-not-enabled-license
matheusbsilva137 6197449
Start hasLicense as undefined
matheusbsilva137 1a9db89
Toggle broadcast on every new connection
matheusbsilva137 cbe2e0d
Improve condition
matheusbsilva137 3b59013
Improve condition again
matheusbsilva137 3dbb8b6
Readd license check (oops)
matheusbsilva137 05364fc
Enable broadcast on license check
matheusbsilva137 3488ccc
Do not assign undefined to hasLicense
matheusbsilva137 2e60162
Remove unnecessary line
matheusbsilva137 8a11ded
Merge branch 'develop' into fix/presence-broadcast-not-enabled-license
matheusbsilva137 361896e
Merge branch 'develop' into fix/presence-broadcast-not-enabled-license
matheusbsilva137 6d49ccf
Enable presence broadcast when license is validated
matheusbsilva137 8d68ec5
dont check troubleshooting setting
sampaiodiego File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@rocket.chat/presence": patch | ||
--- | ||
|
||
Fixed presence broadcast being disabled on server restart |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks expensive, doesn't it? potentially two trips for every new connection?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it did 😬
I've just had a better idea, I'm now checking the
broadcastEnabled
property to make sure that presence broadcast is always enabled when there's a valid license (so we just do it once, not at every new connection).