Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: License V3 #30287

Merged
merged 38 commits into from
Sep 28, 2023
Merged

feat: License V3 #30287

merged 38 commits into from
Sep 28, 2023

Conversation

lmauromb
Copy link
Contributor

@lmauromb lmauromb commented Sep 5, 2023

Proposed changes (including videos or screenshots)

  • new package/jwt with sign and veriy functions to create a JWT given a JS object.
    • uses jose
    • by default uses algorithm RS256 for the public/private keys.
  • new License package, ee/package/license
    • new definition V3 and previous License definition will be renamed as LicenseV2
    • package handles both definitions
    • previous license references were updated to use this new package

Issue(s)

https://rocketchat.atlassian.net/browse/NBJ-292

Steps to test or reproduce

Further comments

@changeset-bot
Copy link

changeset-bot bot commented Sep 5, 2023

🦋 Changeset detected

Latest commit: 79fe515

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 31 packages
Name Type
@rocket.chat/license Minor
@rocket.chat/jwt Minor
@rocket.chat/omnichannel-services Minor
@rocket.chat/omnichannel-transcript Minor
@rocket.chat/authorization-service Minor
@rocket.chat/stream-hub-service Minor
@rocket.chat/presence-service Minor
@rocket.chat/account-service Minor
@rocket.chat/core-services Minor
@rocket.chat/model-typings Minor
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/ddp-streamer Minor
@rocket.chat/queue-worker Minor
@rocket.chat/presence Minor
@rocket.chat/meteor Minor
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/ui-contexts Major
@rocket.chat/api-client Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/ddp-client Patch
@rocket.chat/instance-status Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #30287 (79fe515) into develop (2872428) will increase coverage by 0.51%.
The diff coverage is 70.97%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #30287      +/-   ##
===========================================
+ Coverage    50.23%   50.74%   +0.51%     
===========================================
  Files          780      801      +21     
  Lines        14475    14952     +477     
  Branches      2616     2721     +105     
===========================================
+ Hits          7271     7587     +316     
- Misses        6809     6945     +136     
- Partials       395      420      +25     
Flag Coverage Δ
e2e 48.40% <83.33%> (-0.19%) ⬇️
unit 62.82% <70.97%> (+2.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@lmauromb lmauromb changed the title feat: jwt package and license v3 type feat: LicenseV3 Sep 13, 2023
@ggazzo ggazzo force-pushed the feat/nbj-295-license-v3-type branch from ce9270b to cb43adc Compare September 18, 2023 17:20
@hugocostadev hugocostadev added this to the 6.5.0 milestone Sep 18, 2023
@ggazzo ggazzo force-pushed the feat/nbj-295-license-v3-type branch 4 times, most recently from 48d1071 to ac3f4bc Compare September 22, 2023 00:40
@lmauromb lmauromb marked this pull request as ready for review September 26, 2023 16:56
@lmauromb lmauromb requested review from a team as code owners September 26, 2023 16:56
@ggazzo ggazzo force-pushed the feat/nbj-295-license-v3-type branch from 37d3e43 to 24062c3 Compare September 28, 2023 19:08
@ggazzo ggazzo force-pushed the feat/nbj-295-license-v3-type branch from 24062c3 to 79fe515 Compare September 28, 2023 19:34
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Sep 28, 2023
@ggazzo ggazzo removed the request for review from pierre-lehnen-rc September 28, 2023 22:15
@ggazzo ggazzo changed the title feat: LicenseV3 feat: LicenseV3 Sep 28, 2023
@ggazzo ggazzo changed the title feat: LicenseV3 feat: License V3 Sep 28, 2023
@ggazzo ggazzo merged commit 5f81a0f into develop Sep 28, 2023
46 checks passed
@ggazzo ggazzo deleted the feat/nbj-295-license-v3-type branch September 28, 2023 22:17
gabriellsh added a commit that referenced this pull request Oct 3, 2023
…e/translationCdn

* 'develop' of github.com:RocketChat/Rocket.Chat: (117 commits)
  chore: do not focus messagebox on mobile devices (#30553)
  chore: add the new endpoints to sync with cloud (#30546)
  fix: in forward search field, user cannot be found by name (Full Name) (#29663)
  chore: set license public key v3 with v2 (#30548)
  chore: adjust callbacks return type (#30547)
  chore: Delete Trigger Endpoint (#30533)
  test: adding missing verifications on message-actions (#30531)
  refactor: Oembed backend (#30228)
  test: refactor API E2E tests for groups endpoints (#30523)
  test: adding missing verifications on threads (#30528)
  chore: refactor cloud sync (#30401)
  refactor: Omni logs (#30322)
  refactor: Livechat Header -> ts (#30255)
  chore: Deprecate un-used meteor method for omnichannel analytics (#30421)
  feat: add supported versions + minimum clients versions to the info endpoint (#30178)
  feat: Auto-enable autotranslate (#30370)
  chore: Prevent call license and registration status endpoints when not enough permission (#30336)
  ci: Security/GitHub jira integration (#29776)
  feat: License V3 (#30287)
  chore: move Omnichannel toolbox section from sidebar room list (#30502)
  ...
debdutdeb pushed a commit that referenced this pull request Oct 26, 2023
Co-authored-by: Pierre Lehnen <[email protected]>
Co-authored-by: Guilherme Gazzo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants