Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing subscription metrics on monolith #30295

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

sampaiodiego
Copy link
Member

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@changeset-bot
Copy link

changeset-bot bot commented Sep 5, 2023

⚠️ No Changeset found

Latest commit: f9222b0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.21%. Comparing base (105a1eb) to head (f9222b0).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #30295      +/-   ##
===========================================
- Coverage    55.48%   54.21%   -1.28%     
===========================================
  Files         2371     2303      -68     
  Lines        52062    50822    -1240     
  Branches     10651    10354     -297     
===========================================
- Hits         28888    27553    -1335     
- Misses       20636    20808     +172     
+ Partials      2538     2461      -77     
Flag Coverage Δ
e2e 52.25% <ø> (-2.46%) ⬇️
unit 75.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Base automatically changed from add-subscription-metrics to develop September 11, 2023 20:41
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Sep 11, 2023
@sampaiodiego sampaiodiego marked this pull request as ready for review September 11, 2023 20:51
@sampaiodiego sampaiodiego requested a review from a team as a code owner September 11, 2023 20:51
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Oct 27, 2023
Copy link
Contributor

dionisio-bot bot commented Apr 26, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@dionisio-bot dionisio-bot bot added stat: QA assured Means it has been tested and approved by a company insider and removed stat: ready to merge PR tested and approved waiting for merge stat: QA skipped labels Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants