feat: User Panel > Tab PENDING #30296
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented the necessary resources to filter the list of users and to return only those who are active, when the active tab is enabled.
Implemented a new filter on the users' page that retrieves the roles list and creates a dropdown menu. When any of its options is selected, it will filter the users' list to display only those with the selected roles. Additionally, I made some minor adjustments to the MultiSelectCustom component and introduced some new hooks.
|
Codecov Report
@@ Coverage Diff @@
## feat/user-panel #30296 +/- ##
===================================================
- Coverage 51.04% 50.45% -0.59%
===================================================
Files 805 776 -29
Lines 15031 14499 -532
Branches 2736 2630 -106
===================================================
- Hits 7673 7316 -357
+ Misses 6930 6782 -148
+ Partials 428 401 -27
Flags with carried forward coverage won't be shown. Click here to find out more. |
Completed the implementation of the users table actions menu by preventing the propagation of the click event that triggered the opening of the contextual bar when the menu was clicked. Also, ensured that the contextual bar only opens when the "Enter" or "Space" keys are used for keyboard navigation and enhanced the options menu in the contextual bar as specified in Figma.
Removed the status from the users page contextual bar (the need to remove this may not be concrete, for now it will be only commented until the final decision is made). Also changed the order of the contextual bar info and changed some minor styles to follow figma specs.
rique223
requested changes
Sep 27, 2023
apps/meteor/client/views/admin/users/hooks/useFilterActiveUsers.ts
Outdated
Show resolved
Hide resolved
rique223
requested changes
Sep 29, 2023
| <Tabs.Item selected={tab === 'new'} onClick={() => setTab('new')}> | ||
| {t('New_users')} | ||
| <Tabs.Item selected={tab === 'pending'} onClick={() => setTab('pending')}> | ||
| {pendingActionsCount === 0 ? t('Pending') : `${t('Pending')} (${pendingActionsCount})`} |
There was a problem hiding this comment.
pendingActionsCount is defined and used but since the set is never ran the number will never change. Why is it incomplete?
Implemented the onClick function of the users table pending tab 'Activate' button and fixed some small UI problems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments