Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(client): async loading #30314

Merged
merged 7 commits into from
Sep 12, 2023
Merged

refactor(client): async loading #30314

merged 7 commits into from
Sep 12, 2023

Conversation

tassoevan
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@changeset-bot
Copy link

changeset-bot bot commented Sep 6, 2023

⚠️ No Changeset found

Latest commit: f38c3bb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tassoevan tassoevan force-pushed the refactor/client-async-loading branch from 503f792 to 43ebbb7 Compare September 7, 2023 01:06
@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #30314 (f38c3bb) into develop (b58aee7) will decrease coverage by 0.22%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #30314      +/-   ##
===========================================
- Coverage    50.15%   49.94%   -0.22%     
===========================================
  Files          781      775       -6     
  Lines        14520    14491      -29     
  Branches      2627     2615      -12     
===========================================
- Hits          7282     7237      -45     
- Misses        6840     6844       +4     
- Partials       398      410      +12     
Flag Coverage Δ
e2e 48.33% <100.00%> (-0.24%) ⬇️
unit 60.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@tassoevan tassoevan force-pushed the refactor/client-async-loading branch from 43ebbb7 to 3188990 Compare September 8, 2023 06:42
@tassoevan tassoevan force-pushed the refactor/client-async-loading branch from 3188990 to 7de8920 Compare September 8, 2023 17:22
@tassoevan tassoevan marked this pull request as ready for review September 8, 2023 18:30
@tassoevan tassoevan requested a review from a team as a code owner September 8, 2023 18:30
@ggazzo ggazzo merged commit 091f248 into develop Sep 12, 2023
40 checks passed
@ggazzo ggazzo deleted the refactor/client-async-loading branch September 12, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants