refactor: Pay the debt of some TODO comments #30338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #30338 +/- ##
===========================================
+ Coverage 49.57% 49.58% +0.01%
===========================================
Files 3317 3321 +4
Lines 81492 81528 +36
Branches 16735 16745 +10
===========================================
+ Hits 40399 40428 +29
+ Misses 36397 36392 -5
- Partials 4696 4708 +12
Flags with carried forward coverage won't be shown. Click here to find out more. |
tassoevan
force-pushed
the
refactor/client-todos
branch
from
c09a0b5 to
0b1f659
Compare
tassoevan
force-pushed
the
refactor/client-todos
branch
from
0b1f659 to
e7046cc
Compare
dougfabris
requested changes
Sep 15, 2023
| @@ -41,7 +38,7 @@ const TextCopy = ({ text, wrapper = defaultWrapperRenderer, ...props }: TextCopy | |||
| {...props} | |||
| > | |||
| <Scrollable vertical>{wrapper(text)}</Scrollable> | |||
| <Button icon='copy' secondary square small flexShrink={0} onClick={onClick} title={t('Copy')} /> | |||
| <Button icon='copy' secondary square small flexShrink={0} onClick={handleClick} title={t('Copy')} /> | |||
There was a problem hiding this comment.
why not:
Suggested change
| <Button icon='copy' secondary square small flexShrink={0} onClick={handleClick} title={t('Copy')} /> | |
| <Button icon='copy' secondary square small flexShrink={0} onClick={() => copy()} title={t('Copy')} /> |
| const { connected, retryTime, status, reconnect } = useConnectionStatus(); | ||
| const reconnectCountdown = useReconnectCountdown(retryTime, status); | ||
| const t = useTranslation(); | ||
| const { t } = useTranslation(); |
There was a problem hiding this comment.
I think its not going to work here, in this file
There was a problem hiding this comment.
I think there's a verification on the provider and just translations with the proper pattern works with react-i18next
gabriellsh
added a commit
that referenced
this pull request
Jan 23, 2024
* 'develop' of github.com:RocketChat/Rocket.Chat: (143 commits) fix: Marketplace apps installed as private showing as installed (#31514) test: fix messaging flaky test (#31512) fix: change the push sound sent when the push is from video conference (#30910) fix: ensure sessionId on Sessions documents (#31487) chore: handle rocket.cat creation and deletion (#31170) chore(agenda): Changes in Agenda API (#31427) refactor: Pay the debt of some TODO comments (#30338) feat: Room header keyboard navigability (#31516) fix: Cron job for clearing OEmbed cache isn't working (#31336) refactor(client): Handling of custom statuses (#31500) fix: Prevent `Fallback forward departments` feature to go on loop when configured as circular chain (#31328) feat: Add `push.test` endpoint (#31289) chore: split UserProvider into two: User and Authentication (#31513) fix: Can't remove channel's password to join (#31507) chore: convert CAS integration code to typescript (#31492) feat: Composer keyboard navigability (#31510) fix: Render warning in Logs - (MessageType.render is deprecated. Use MessageType.message instead) (#31426) feat: Convert emoji shortname to unicode on notification emails. (#31225) chore: Normalize `ButtonGroup` (#31499) chore: improve type definitions for login service configurations (#31491) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments