Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: empty vertical bar for administration menu when admin disable 'access-marketplace' #30341

Closed
wants to merge 1 commit into from

Conversation

Ninad3721
Copy link

@Ninad3721 Ninad3721 commented Sep 10, 2023

The administration dropdown on the user side was showing an empty vertical bar when there is no content present in it (when admin disable the access marketplace for user there is no content in the dropdown of administration), by this PR the administration dropdown will be removed if there is no content in it.

Proposed changes (including videos or screenshots)

https://www.loom.com/share/89ff8204aa1c4cc4aa3b1c661d2e7598?sid=c0122a9d-ff5e-4c1c-8dc4-77097e9c49f1

Issue(s)

Closes #30159

Steps to test or reproduce

1.Disable 'access-marketplace' permission for users
2.Log in as a normal user
3.Click on the 'Administration' menu

Further comments

@Ninad3721 Ninad3721 requested a review from a team as a code owner September 10, 2023 13:06
@changeset-bot
Copy link

changeset-bot bot commented Sep 10, 2023

⚠️ No Changeset found

Latest commit: f73d889

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dougfabris
Copy link
Member

Hi there, thanks for the contribution! 🚀 💯

Closing this PR because it's stale now and it will be fixed here: #30319.


Questions? Help needed? Feature Requests?

  • Join our Open Server in the #support channel and feel free to raise a question
  • Join our Community Forum and search/create a post there

@dougfabris dougfabris closed this Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disabling 'access-marketplace' permission for users show an empty 'Administration' tab
2 participants