Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: More Business Hour tests surrounding user activation/deactivation #30343

Merged
merged 6 commits into from
Sep 11, 2023

Conversation

murtaza98
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Added tests to cover the issues we fixed here -> #30284 #30303

@changeset-bot
Copy link

changeset-bot bot commented Sep 11, 2023

⚠️ No Changeset found

Latest commit: 1dd0805

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Merging #30343 (1dd0805) into develop (ba856a2) will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #30343      +/-   ##
===========================================
- Coverage    50.15%   50.06%   -0.09%     
===========================================
  Files          781      781              
  Lines        14520    14520              
  Branches      2627     2627              
===========================================
- Hits          7282     7269      -13     
  Misses        6840     6840              
- Partials       398      411      +13     
Flag Coverage Δ
e2e 48.47% <ø> (-0.10%) ⬇️
unit 60.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@murtaza98 murtaza98 marked this pull request as ready for review September 11, 2023 11:56
@murtaza98 murtaza98 requested a review from a team as a code owner September 11, 2023 11:56
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Sep 11, 2023
@murtaza98 murtaza98 requested a review from a team September 11, 2023 14:11
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Sep 11, 2023
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Sep 11, 2023
@KevLehman KevLehman added this to the 6.4.0 milestone Sep 11, 2023
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Sep 11, 2023
@kodiakhq kodiakhq bot merged commit be98f53 into develop Sep 11, 2023
@kodiakhq kodiakhq bot deleted the test/more-about-BH branch September 11, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants