Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: Reports by-department showing null when department no longer exists #30350

Merged
merged 2 commits into from
Sep 12, 2023

Conversation

KevLehman
Copy link
Contributor

OC-1274

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@changeset-bot
Copy link

changeset-bot bot commented Sep 11, 2023

⚠️ No Changeset found

Latest commit: 0f14686

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Merging #30350 (0f14686) into develop (091f248) will decrease coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #30350      +/-   ##
===========================================
- Coverage    50.15%   50.01%   -0.14%     
===========================================
  Files          781      775       -6     
  Lines        14520    14491      -29     
  Branches      2627     2619       -8     
===========================================
- Hits          7282     7248      -34     
+ Misses        6840     6834       -6     
- Partials       398      409      +11     
Flag Coverage Δ
e2e 48.42% <ø> (-0.16%) ⬇️
unit 60.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Sep 12, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Sep 12, 2023
@kodiakhq kodiakhq bot merged commit 8202f27 into develop Sep 12, 2023
42 checks passed
@kodiakhq kodiakhq bot deleted the fix/report-department-showing-null branch September 12, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
squad: omnichannel stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants