Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Consider only sessions from last few days for SAU/MAU #30354

Merged
merged 5 commits into from
Sep 12, 2023

Conversation

sampaiodiego
Copy link
Member

Proposed changes (including videos or screenshots)

It changes the filter for the cronjob that runs daily to calculate the workspace MAU to fetch sessions only from 3 days ago.

This change is will only have an impact in case the cronjob has been skipped for quite a few days and will prevent large workspace from having the database hammered when it runs again.

Issue(s)

Steps to test or reproduce

Further comments

@sampaiodiego sampaiodiego added this to the 6.3.5 milestone Sep 11, 2023
@sampaiodiego sampaiodiego requested a review from a team as a code owner September 11, 2023 18:24
@changeset-bot
Copy link

changeset-bot bot commented Sep 11, 2023

🦋 Changeset detected

Latest commit: 4853f32

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 29 packages
Name Type
@rocket.chat/model-typings Patch
@rocket.chat/meteor Patch
@rocket.chat/models Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/omnichannel-services Patch
rocketchat-services Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/instance-status Patch
@rocket.chat/presence Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/api-client Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@sampaiodiego sampaiodiego changed the title fix: Consider only sessions from last few days for SAU fix: Consider only sessions from last few days for SAU/MAU Sep 11, 2023
@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Merging #30354 (4853f32) into develop (be98f53) will decrease coverage by 0.09%.
Report is 2 commits behind head on develop.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #30354      +/-   ##
===========================================
- Coverage    50.15%   50.06%   -0.09%     
===========================================
  Files          781      781              
  Lines        14520    14520              
  Branches      2627     2627              
===========================================
- Hits          7282     7269      -13     
+ Misses        6840     6839       -1     
- Partials       398      412      +14     
Flag Coverage Δ
e2e 48.47% <ø> (-0.10%) ⬇️
unit 60.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo merged commit f556518 into develop Sep 12, 2023
@ggazzo ggazzo deleted the get-sessions-from-last-three-days-for-sau branch September 12, 2023 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants