-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Consider only sessions from last few days for SAU/MAU #30354
Conversation
🦋 Changeset detectedLatest commit: 4853f32 The changes in this PR will be included in the next version bump. This PR includes changesets to release 29 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## develop #30354 +/- ##
===========================================
- Coverage 50.15% 50.06% -0.09%
===========================================
Files 781 781
Lines 14520 14520
Branches 2627 2627
===========================================
- Hits 7282 7269 -13
+ Misses 6840 6839 -1
- Partials 398 412 +14
Flags with carried forward coverage won't be shown. Click here to find out more. |
…m:RocketChat/Rocket.Chat into get-sessions-from-last-three-days-for-sau
Proposed changes (including videos or screenshots)
It changes the filter for the cronjob that runs daily to calculate the workspace MAU to fetch sessions only from 3 days ago.
This change is will only have an impact in case the cronjob has been skipped for quite a few days and will prevent large workspace from having the database hammered when it runs again.
Issue(s)
Steps to test or reproduce
Further comments