-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Revert "fix: update type of message bridge's create method" #30355
Conversation
This reverts commit 9f6efb1.
|
Codecov Report
@@ Coverage Diff @@
## develop #30355 +/- ##
===========================================
- Coverage 50.17% 50.10% -0.08%
===========================================
Files 781 775 -6
Lines 14514 14491 -23
Branches 2623 2618 -5
===========================================
- Hits 7282 7260 -22
+ Misses 6835 6820 -15
- Partials 397 411 +14
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:(
Reverts #30321
The changes break some conventions on the Apps-Engine API.
For more details, see RocketChat/Rocket.Chat.Apps-engine#662