Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Revert "fix: update type of message bridge's create method" #30355

Merged
merged 5 commits into from
Sep 12, 2023

Conversation

d-gubert
Copy link
Member

Reverts #30321

The changes break some conventions on the Apps-Engine API.

For more details, see RocketChat/Rocket.Chat.Apps-engine#662

@changeset-bot
Copy link

changeset-bot bot commented Sep 11, 2023

⚠️ No Changeset found

Latest commit: 9300baa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Merging #30355 (9300baa) into develop (3656fd4) will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #30355      +/-   ##
===========================================
- Coverage    50.17%   50.10%   -0.08%     
===========================================
  Files          781      775       -6     
  Lines        14514    14491      -23     
  Branches      2623     2618       -5     
===========================================
- Hits          7282     7260      -22     
+ Misses        6835     6820      -15     
- Partials       397      411      +14     
Flag Coverage Δ
e2e 48.51% <ø> (-0.09%) ⬇️
unit 60.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@d-gubert d-gubert marked this pull request as ready for review September 12, 2023 13:33
@d-gubert d-gubert requested a review from a team as a code owner September 12, 2023 13:33
@d-gubert d-gubert added this to the 6.4.0 milestone Sep 12, 2023
Copy link
Contributor

@AllanPazRibeiro AllanPazRibeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:(

@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Sep 12, 2023
@casalsgh casalsgh removed the stat: ready to merge PR tested and approved waiting for merge label Sep 12, 2023
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Sep 12, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Sep 12, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Sep 12, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Sep 12, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Sep 12, 2023
@kodiakhq kodiakhq bot merged commit 711bb92 into develop Sep 12, 2023
42 checks passed
@kodiakhq kodiakhq bot deleted the revert-30321-new/dmnotify branch September 12, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants