Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Auto-translate doesn't work on E2E rooms #30369

Merged
merged 33 commits into from
Oct 10, 2023
Merged

Conversation

matheusbsilva137
Copy link
Member

@matheusbsilva137 matheusbsilva137 commented Sep 12, 2023

Proposed changes (including videos or screenshots)

  • Disable every member's auto-translation when E2E is enabled in a room;
  • Do not allow users to enable auto-translate in an E2E enabled room;
  • Add information in the UI (toasts and a callout in the auto-translate sidebar) about this restriction.

Issue(s)

Steps to test or reproduce

Further comments

SUP-284

@changeset-bot
Copy link

changeset-bot bot commented Sep 12, 2023

🦋 Changeset detected

Latest commit: b0e578a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/model-typings Patch
@rocket.chat/models Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/omnichannel-services Patch
rocketchat-services Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/instance-status Patch
@rocket.chat/presence Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Merging #30369 (b0e578a) into develop (03315b2) will decrease coverage by 0.12%.
The diff coverage is 55.55%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #30369      +/-   ##
===========================================
- Coverage    51.29%   51.18%   -0.12%     
===========================================
  Files          811      804       -7     
  Lines        15080    15107      +27     
  Branches      2754     2768      +14     
===========================================
- Hits          7735     7732       -3     
- Misses        6935     6950      +15     
- Partials       410      425      +15     
Flag Coverage Δ
e2e 48.49% <55.55%> (-0.07%) ⬇️
unit 64.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@matheusbsilva137 matheusbsilva137 marked this pull request as ready for review September 18, 2023 21:31
@matheusbsilva137 matheusbsilva137 requested review from a team as code owners September 18, 2023 21:31
guijun13
guijun13 previously approved these changes Sep 19, 2023
@tassoevan tassoevan dismissed stale reviews from heitortanoue and guijun13 via 189e447 October 10, 2023 13:29
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Oct 10, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Oct 10, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Oct 10, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Oct 10, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Oct 10, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Oct 10, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Oct 10, 2023
@kodiakhq kodiakhq bot merged commit 223dce1 into develop Oct 10, 2023
43 checks passed
@kodiakhq kodiakhq bot deleted the fix/autotranslate-e2e branch October 10, 2023 23:00
gabriellsh added a commit that referenced this pull request Oct 11, 2023
…/mentionBot

* 'develop' of github.com:RocketChat/Rocket.Chat:
  fix: Auto-translate doesn't work on E2E rooms (#30369)
  test: Validate monitors data access (#30593)
  fix: reset file input after uploading file (#30529)
  refactor: AutoCompleteTagsMultiple to TS (#30577)
  fix: DM room stay "read only" after the deactivate and reactivate user with "guest" role (#30459)
  fix: Change plan name from Enterprise to Premium on marketplace filtering (#30616)
  regression: test license from cloud (#30609)
  fix: Unable to send attachments via email as an omni-agent (#30525)
  ci: fix lint task
  fix: cloud alerts (#30607)
  feat: License trigger cloud sync after reach limits (#30603)
  chore: Change plan name Enterprise to Premium on marketplace (#30487)
  chore: Improve cache of static files (#30290)
  regression: Undefined MAC count on startup cloud sync (#30605)
  chore: Change Records page name to Reports (#30513)
hugocostadev pushed a commit that referenced this pull request Oct 11, 2023
Co-authored-by: Guilherme Jun Grillo <[email protected]>
Co-authored-by: Tasso Evangelista <[email protected]>
debdutdeb pushed a commit that referenced this pull request Oct 26, 2023
Co-authored-by: Guilherme Jun Grillo <[email protected]>
Co-authored-by: Tasso Evangelista <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
squad: team-collab stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants