Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Auto-enable autotranslate #30370

Merged
merged 8 commits into from
Sep 29, 2023
Merged

feat: Auto-enable autotranslate #30370

merged 8 commits into from
Sep 29, 2023

Conversation

gabriellsh
Copy link
Member

@gabriellsh gabriellsh commented Sep 12, 2023

Proposed changes (including videos or screenshots)

This PR proposes a new setting which once active will automatically enable autotranslate upon joining a room if the user has his language set to any different than the server's config.

Issue(s)

CE-15

Steps to test or reproduce

Further comments

@changeset-bot
Copy link

changeset-bot bot commented Sep 12, 2023

🦋 Changeset detected

Latest commit: 4707b17

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 29 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/models Patch
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Merging #30370 (4707b17) into develop (27c75f1) will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #30370      +/-   ##
===========================================
- Coverage    50.23%   50.18%   -0.06%     
===========================================
  Files          780      774       -6     
  Lines        14476    14455      -21     
  Branches      2617     2613       -4     
===========================================
- Hits          7272     7254      -18     
+ Misses        6809     6792      -17     
- Partials       395      409      +14     
Flag Coverage Δ
e2e 48.53% <ø> (-0.06%) ⬇️
unit 60.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

gabriellsh and others added 4 commits September 13, 2023 11:24
…Chat into new/AutoAutotranslate

* 'new/AutoAutotranslate' of github.com:RocketChat/Rocket.Chat:
  Add changeset
@gabriellsh gabriellsh marked this pull request as ready for review September 13, 2023 22:21
@gabriellsh gabriellsh requested a review from a team as a code owner September 13, 2023 22:21
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Sep 26, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Sep 26, 2023
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Sep 27, 2023
@ggazzo ggazzo merged commit 1642bad into develop Sep 29, 2023
@ggazzo ggazzo deleted the new/AutoAutotranslate branch September 29, 2023 04:50
gabriellsh added a commit that referenced this pull request Oct 3, 2023
…e/translationCdn

* 'develop' of github.com:RocketChat/Rocket.Chat: (117 commits)
  chore: do not focus messagebox on mobile devices (#30553)
  chore: add the new endpoints to sync with cloud (#30546)
  fix: in forward search field, user cannot be found by name (Full Name) (#29663)
  chore: set license public key v3 with v2 (#30548)
  chore: adjust callbacks return type (#30547)
  chore: Delete Trigger Endpoint (#30533)
  test: adding missing verifications on message-actions (#30531)
  refactor: Oembed backend (#30228)
  test: refactor API E2E tests for groups endpoints (#30523)
  test: adding missing verifications on threads (#30528)
  chore: refactor cloud sync (#30401)
  refactor: Omni logs (#30322)
  refactor: Livechat Header -> ts (#30255)
  chore: Deprecate un-used meteor method for omnichannel analytics (#30421)
  feat: add supported versions + minimum clients versions to the info endpoint (#30178)
  feat: Auto-enable autotranslate (#30370)
  chore: Prevent call license and registration status endpoints when not enough permission (#30336)
  ci: Security/GitHub jira integration (#29776)
  feat: License V3 (#30287)
  chore: move Omnichannel toolbox section from sidebar room list (#30502)
  ...
@scuciatto scuciatto added this to the 6.4.1 milestone Oct 6, 2023
sampaiodiego pushed a commit that referenced this pull request Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants