test: Improve tests for legacy omnichannel analytics #30379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov Report
@@ Coverage Diff @@
## develop #30379 +/- ##
===========================================
+ Coverage 51.31% 51.37% +0.06%
===========================================
Files 811 805 -6
Lines 15081 15106 +25
Branches 2753 2760 +7
===========================================
+ Hits 7739 7761 +22
+ Misses 6933 6921 -12
- Partials 409 424 +15
Flags with carried forward coverage won't be shown. Click here to find out more. |
KevLehman
previously requested changes
Sep 14, 2023
apps/meteor/app/livechat/server/methods/getAgentOverviewData.ts
Outdated
Show resolved
Hide resolved
apps/meteor/app/livechat/server/methods/getAnalyticsOverviewData.ts
Outdated
Show resolved
Hide resolved
This reverts commit 3aac69f.
murtaza98
dismissed
KevLehman’s stale review
Done with the changes; Thanks Kevin!
KevLehman
approved these changes
Oct 6, 2023
dionisio-bot
bot
added
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
gabriellsh
added a commit
that referenced
this pull request
Oct 9, 2023
…/mentionBot * 'develop' of github.com:RocketChat/Rocket.Chat: (68 commits) fix: don't save the filter value on offlineMessageChannelName (#30576) feat: New permission to kick users (#30535) chore: improve message link focus (#30578) chore: Add required visual indication on `EditRoom` name input (#30589) fix: user dropdown menu position on RTL layout (#30490) chore: add missing `_id` field to `AtLeast` (#30592) test: Improve tests for legacy omnichannel analytics (#30379) fix: Remove monitors query restrictions on update (#30550) chore: license v3 invalidation (#30585) chore: `CreateDirectMessage` a11y form improvements (#30581) chore: `CreateDiscussion` a11y improvements (#30583) chore: License v3 - behavior and limited reached triggers (#30561) chore: Improve `groups.create` endpoint for large amounts of members (#30499) feat: Monitors able to forward chats without joining (#30549) feat: Deployment Fingerprint (#30411) chore: fix flaky agents & custom fields tables tests (#30580) feat: Save visitor's activity on agent's interaction (#30222) chore: update mentions upsell modal content (#30503) fix: font-disabled color (#30569) chore: anchor text-decoration rules (#30485) ...
debdutdeb
pushed a commit
that referenced
this pull request
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
https://rocketchat.atlassian.net/browse/OC-1272
Steps to test or reproduce
Further comments