Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: Move queue-timeout setting to CE and remove dependency on waiting queue #30386

Merged
merged 4 commits into from
Sep 14, 2023

Conversation

KevLehman
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@changeset-bot
Copy link

changeset-bot bot commented Sep 14, 2023

⚠️ No Changeset found

Latest commit: ffd5b88

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #30386 (ffd5b88) into develop (7137a19) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #30386      +/-   ##
===========================================
- Coverage    50.17%   50.14%   -0.03%     
===========================================
  Files          781      775       -6     
  Lines        14514    14491      -23     
  Branches      2623     2618       -5     
===========================================
- Hits          7282     7267      -15     
+ Misses        6835     6812      -23     
- Partials       397      412      +15     
Flag Coverage Δ
e2e 48.56% <ø> (-0.03%) ⬇️
unit 60.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@KevLehman KevLehman changed the base branch from develop to release-6.4.0 September 14, 2023 15:23
@KevLehman KevLehman added this to the 6.4.0 milestone Sep 14, 2023
@KevLehman KevLehman marked this pull request as ready for review September 14, 2023 17:55
@KevLehman KevLehman requested review from a team as code owners September 14, 2023 17:55
@ggazzo ggazzo changed the title fix: Move queue-timeout setting to CE and remove dependency on waiting queue regression: Move queue-timeout setting to CE and remove dependency on waiting queue Sep 14, 2023
@ggazzo ggazzo merged commit 886631b into release-6.4.0 Sep 14, 2023
43 checks passed
@ggazzo ggazzo deleted the fix/queue-timeout-setting-ce branch September 14, 2023 18:20
gabriellsh added a commit that referenced this pull request Sep 19, 2023
…ove/iframeLogin

* 'develop' of github.com:RocketChat/Rocket.Chat: (29 commits)
  fix: Disables `GenericMenu` without any sections or items (#30319)
  i18n: Language update from LingoHub 🤖 on 2023-09-18Z (#30426)
  chore:  remove connectToCloud option (#30430)
  chore: remove Troubleshoot options (#30429)
  chore: bump fuselage packages (#30424)
  chore: Webhooks page refactor (#30274)
  chore: color palette changes (#30385)
  fix: increase cron job check delay to 1 min (#30402)
  fix: Presence broadcast isn't enabled after license validation (#30282)
  test: create non private team and readonly team (#30371)
  Bump version to 6.5.0-develop
  refactor: Implement functional code for the 'useFilteredApps' hook (#30279)
  Release 6.4.0-rc.1
  Release 6.3.6
  regression: Login page callout messages (#30399)
  test: tests for muting and unmuting (#30286)
  regression: Fix rooms table not showing teams (#30361)
  regression: Move queue-timeout setting to CE and remove dependency on waiting queue (#30386)
  fix: engagement dashboard not working (#30277)
  Bump 6.3.6
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants