Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: CSS adjustments in ActionManagerBusyState #30388

Merged
merged 6 commits into from
Sep 19, 2023

Conversation

tiagoevanp
Copy link
Contributor

@tiagoevanp tiagoevanp commented Sep 14, 2023

Proposed changes (including videos or screenshots)

Fix:

  • Text color
  • Positioning
  • Action overlap

Issue(s)

Steps to test or reproduce

Further comments

@tiagoevanp tiagoevanp added this to the 6.5.0 milestone Sep 14, 2023
@tiagoevanp tiagoevanp requested a review from a team as a code owner September 14, 2023 05:57
@changeset-bot
Copy link

changeset-bot bot commented Sep 14, 2023

⚠️ No Changeset found

Latest commit: 38ff3b9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #30388 (38ff3b9) into release-6.4.0 (f634601) will decrease coverage by 0.20%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##           release-6.4.0   #30388      +/-   ##
=================================================
- Coverage          50.17%   49.97%   -0.20%     
=================================================
  Files                781      775       -6     
  Lines              14514    14491      -23     
  Branches            2623     2618       -5     
=================================================
- Hits                7282     7242      -40     
- Misses              6835     6837       +2     
- Partials             397      412      +15     
Flag Coverage Δ
e2e 48.37% <ø> (-0.23%) ⬇️
unit 60.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

tassoevan
tassoevan previously approved these changes Sep 14, 2023
@tassoevan tassoevan changed the title chore: Fix the text color theme in ActionManagerBusyState fix: Fix the text color theme in ActionManagerBusyState Sep 14, 2023
@tassoevan tassoevan changed the title fix: Fix the text color theme in ActionManagerBusyState fix: Text color in ActionManagerBusyState Sep 14, 2023
@tassoevan tassoevan changed the title fix: Text color in ActionManagerBusyState regression: Text color in ActionManagerBusyState Sep 14, 2023
@tassoevan tassoevan modified the milestones: 6.5.0, 6.4.0 Sep 14, 2023
@sampaiodiego
Copy link
Member

is it a regression for 6.4.0? if so it needs to target the branch release-6.4.0

@tiagoevanp tiagoevanp changed the base branch from develop to release-6.4.0 September 15, 2023 02:54
@tiagoevanp tiagoevanp dismissed tassoevan’s stale review September 15, 2023 02:54

The base branch was changed.

@tiagoevanp tiagoevanp changed the title regression: Text color in ActionManagerBusyState regression: CSS adjustments in ActionManagerBusyState Sep 15, 2023
@ggazzo ggazzo merged commit 415ae0e into release-6.4.0 Sep 19, 2023
@ggazzo ggazzo deleted the fix/action-manager-busy-color branch September 19, 2023 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants