Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: Reports button visible when downgrading from EE to CE #30394

Merged
merged 5 commits into from
Sep 25, 2023

Conversation

KevLehman
Copy link
Contributor

OC-1287

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@changeset-bot
Copy link

changeset-bot bot commented Sep 14, 2023

⚠️ No Changeset found

Latest commit: 443717d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@KevLehman KevLehman added this to the 6.4.0 milestone Sep 14, 2023
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #30394 (443717d) into release-6.4.0 (2a4213a) will decrease coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                Coverage Diff                @@
##           release-6.4.0   #30394      +/-   ##
=================================================
- Coverage          50.12%   49.98%   -0.14%     
=================================================
  Files                775      775              
  Lines              14483    14484       +1     
  Branches            2616     2616              
=================================================
- Hits                7259     7240      -19     
- Misses              6831     6836       +5     
- Partials             393      408      +15     
Flag Coverage Δ
e2e 48.35% <100.00%> (-0.15%) ⬇️
unit 60.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@KevLehman KevLehman marked this pull request as ready for review September 20, 2023 19:35
@KevLehman KevLehman requested review from a team as code owners September 20, 2023 19:35
MartinSchoeler
MartinSchoeler previously approved these changes Sep 25, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Sep 25, 2023
@kodiakhq kodiakhq bot merged commit 7e75bd8 into release-6.4.0 Sep 25, 2023
44 checks passed
@kodiakhq kodiakhq bot deleted the regression/reports-ce branch September 25, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
squad: omnichannel stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants