-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Adapt some messaging features to work without the DB watcher #30408
chore: Adapt some messaging features to work without the DB watcher #30408
Conversation
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #30408 +/- ##
===========================================
+ Coverage 46.31% 51.09% +4.78%
===========================================
Files 766 807 +41
Lines 14675 15141 +466
Branches 2753 2820 +67
===========================================
+ Hits 6797 7737 +940
+ Misses 7479 6969 -510
- Partials 399 435 +36
Flags with carried forward coverage won't be shown. Click here to find out more. |
…sage-events-without-db-watcher
…sage-events-without-db-watcher
…sage-events-without-db-watcher
…sage-events-without-db-watcher
…sage-events-without-db-watcher
…sage-events-without-db-watcher
…sage-events-without-db-watcher
…sage-events-without-db-watcher
callbacks.add( | ||
'afterSaveMessage', | ||
(message, room) => notifyUsersOnMessage(message, room), | ||
callbacks.priority.MEDIUM, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason to change this to MEDIUM? just curious
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comes from the discussion feature. I changed that because I need that to run before the discussion callback, otherwise, we would end up without the correct number of messages within that room.
await Rooms.incMsgCountAndSetLastMessageById(message.rid, 1, message.ts, settings.get('Store_Last_Message') && message); |
Proposed changes (including videos or screenshots)
This PR adapts the following features to work without the DB watcher:
ARCH-1209
ARCH-1210
ARCH-1211
ARCH-1212
ARCH-1213
ARCH-1215
ARCH-1216
ARCH-1241
ARCH-1234
ARCH-1230
Issue(s)
Steps to test or reproduce
Further comments