Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Embedded login route #30410

Closed
wants to merge 11 commits into from
Closed

chore: Embedded login route #30410

wants to merge 11 commits into from

Conversation

gabriellsh
Copy link
Member

@gabriellsh gabriellsh commented Sep 15, 2023

Proposed changes (including videos or screenshots)

Issue(s)

CE-18

Steps to test or reproduce

Further comments

@changeset-bot
Copy link

changeset-bot bot commented Sep 15, 2023

🦋 Changeset detected

Latest commit: 60665e2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 29 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/models Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Merging #30410 (60665e2) into develop (27c75f1) will decrease coverage by 0.43%.
Report is 10 commits behind head on develop.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #30410      +/-   ##
===========================================
- Coverage    50.23%   49.80%   -0.43%     
===========================================
  Files          780      766      -14     
  Lines        14476    14671     +195     
  Branches      2617     2695      +78     
===========================================
+ Hits          7272     7307      +35     
- Misses        6809     6952     +143     
- Partials       395      412      +17     
Flag Coverage Δ
e2e 47.25% <ø> (-1.35%) ⬇️
unit 62.93% <ø> (+2.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

gabriellsh and others added 5 commits September 19, 2023 15:54
…ove/iframeLogin

* 'develop' of github.com:RocketChat/Rocket.Chat: (29 commits)
  fix: Disables `GenericMenu` without any sections or items (#30319)
  i18n: Language update from LingoHub 🤖 on 2023-09-18Z (#30426)
  chore:  remove connectToCloud option (#30430)
  chore: remove Troubleshoot options (#30429)
  chore: bump fuselage packages (#30424)
  chore: Webhooks page refactor (#30274)
  chore: color palette changes (#30385)
  fix: increase cron job check delay to 1 min (#30402)
  fix: Presence broadcast isn't enabled after license validation (#30282)
  test: create non private team and readonly team (#30371)
  Bump version to 6.5.0-develop
  refactor: Implement functional code for the 'useFilteredApps' hook (#30279)
  Release 6.4.0-rc.1
  Release 6.3.6
  regression: Login page callout messages (#30399)
  test: tests for muting and unmuting (#30286)
  regression: Fix rooms table not showing teams (#30361)
  regression: Move queue-timeout setting to CE and remove dependency on waiting queue (#30386)
  fix: engagement dashboard not working (#30277)
  Bump 6.3.6
  ...
@gabriellsh gabriellsh marked this pull request as ready for review September 19, 2023 19:00
@gabriellsh gabriellsh requested a review from a team as a code owner September 19, 2023 19:00
apps/meteor/public/iframe/login.js Fixed Show fixed Hide fixed
apps/meteor/public/iframe/login.js Fixed Show fixed Hide fixed
apps/meteor/public/iframe/login.js Outdated Show resolved Hide resolved
@gabriellsh gabriellsh marked this pull request as draft September 19, 2023 22:39
…ove/iframeLogin

* 'develop' of github.com:RocketChat/Rocket.Chat: (33 commits)
  feat: New records page analytics tab (#30373)
  chore: Changing some key translations - Setup Wizard (#30462)
  feat: use isolated-vm to run integration scripts (#30229)
  fix: do not broadcast events from the local node to the local service (duplicated event) (#30446)
  fix: Microsoft autotranslate not working (#30390)
  chore: `ResetPasswordPage` a11y improvements (#30479)
  chore: `ResetPasswordForm` a11y improvements (#30476)
  chore: Move bad words filter callback to service (#30241)
  fix: Message disappears from room after deletion even if "Show Deleted Status" is enabled (#30452)
  chore: add tooltip to mentions (#30445)
  chore: bump mongo deps (#30450)
  ci: patch mongo type definitions (#30449)
  chore: cache incremental ts check (#30447)
  Release 6.4.0-rc.4
  Release 6.4.0-rc.3
  chore: update meteor 2.13.0 (#29989)
  chore: Assertion accuracy on registration test (#30440)
  ci: Add step to notify external services about a new release after Docker image publish (#30436)
  regression: close button not working on contact history (#30432)
  regression: custom fields not showing in current chats (#30428)
  ...
@gabriellsh gabriellsh changed the title chore: Iframe login route chore: Embedded login route Sep 27, 2023
@gabriellsh gabriellsh marked this pull request as ready for review September 27, 2023 19:35
@gabriellsh gabriellsh marked this pull request as draft October 2, 2023 18:37
@gabriellsh gabriellsh closed this Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants