Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Deployment Fingerprint #30411

Merged
merged 18 commits into from
Oct 5, 2023
Merged

feat: Deployment Fingerprint #30411

merged 18 commits into from
Oct 5, 2023

Conversation

rodrigok
Copy link
Member

@rodrigok rodrigok commented Sep 15, 2023

https://rocketchat.atlassian.net/browse/NBJ-264

TODO

  • Learn more link
  • Change env variable

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@changeset-bot
Copy link

changeset-bot bot commented Sep 15, 2023

🦋 Changeset detected

Latest commit: 758fcc0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/core-typings Minor
@rocket.chat/model-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Merging #30411 (758fcc0) into develop (dea1fe9) will decrease coverage by 3.98%.
Report is 1 commits behind head on develop.
The diff coverage is 46.15%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #30411      +/-   ##
===========================================
- Coverage    50.91%   46.94%   -3.98%     
===========================================
  Files          809      795      -14     
  Lines        15005    14782     -223     
  Branches      2727     2726       -1     
===========================================
- Hits          7640     6939     -701     
- Misses        6956     7443     +487     
+ Partials       409      400       -9     
Flag Coverage Δ
unit 62.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@rodrigok rodrigok force-pushed the fingerprint branch 2 times, most recently from 30b2e63 to d29ce1a Compare September 16, 2023 14:17
@rodrigok rodrigok changed the title chore: Deployment Fingerprint feat: Deployment Fingerprint Sep 16, 2023
@rodrigok rodrigok marked this pull request as ready for review September 22, 2023 21:28
@rodrigok rodrigok requested review from a team as code owners September 22, 2023 21:28
Copy link
Member

@r0zbot r0zbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple fixes to match the new env var name.

.changeset/tidy-bears-applaud.md Outdated Show resolved Hide resolved
apps/meteor/server/settings/misc.ts Outdated Show resolved Hide resolved
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Sep 26, 2023
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Sep 26, 2023
ggazzo
ggazzo previously approved these changes Oct 3, 2023
@rodrigok rodrigok added this to the 6.5.0 milestone Oct 5, 2023
@ggazzo ggazzo merged commit ec1b2b9 into develop Oct 5, 2023
13 of 14 checks passed
@ggazzo ggazzo deleted the fingerprint branch October 5, 2023 22:07
gabriellsh added a commit that referenced this pull request Oct 6, 2023
…ove/ui-caching

* 'develop' of github.com:RocketChat/Rocket.Chat:
  fix: Remove monitors query restrictions on update (#30550)
  chore: license v3 invalidation (#30585)
  chore: `CreateDirectMessage` a11y form improvements (#30581)
  chore: `CreateDiscussion` a11y improvements (#30583)
  chore: License v3 - behavior and limited reached triggers (#30561)
  chore: Improve `groups.create` endpoint for large amounts of members (#30499)
  feat: Monitors able to forward chats without joining (#30549)
  feat: Deployment Fingerprint (#30411)
  chore: fix flaky agents & custom fields tables tests (#30580)
gabriellsh added a commit that referenced this pull request Oct 9, 2023
…/mentionBot

* 'develop' of github.com:RocketChat/Rocket.Chat: (68 commits)
  fix: don't save the filter value on offlineMessageChannelName (#30576)
  feat: New permission to kick users (#30535)
  chore: improve message link focus (#30578)
  chore: Add required visual indication on `EditRoom` name input (#30589)
  fix: user dropdown menu position on RTL layout (#30490)
  chore: add missing `_id` field to `AtLeast` (#30592)
  test: Improve tests for legacy omnichannel analytics  (#30379)
  fix: Remove monitors query restrictions on update (#30550)
  chore: license v3 invalidation (#30585)
  chore: `CreateDirectMessage` a11y form improvements (#30581)
  chore: `CreateDiscussion` a11y improvements (#30583)
  chore: License v3 - behavior and limited reached triggers (#30561)
  chore: Improve `groups.create` endpoint for large amounts of members (#30499)
  feat: Monitors able to forward chats without joining (#30549)
  feat: Deployment Fingerprint (#30411)
  chore: fix flaky agents & custom fields tables tests (#30580)
  feat: Save visitor's activity on agent's interaction (#30222)
  chore: update mentions upsell modal content (#30503)
  fix: font-disabled color (#30569)
  chore: anchor text-decoration rules (#30485)
  ...
debdutdeb pushed a commit that referenced this pull request Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants