Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create Ephemeral Message for mentioned users that are not in the channel #30412

Conversation

PedroRorato
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@changeset-bot
Copy link

changeset-bot bot commented Sep 15, 2023

⚠️ No Changeset found

Latest commit: bcc9882

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Merging #30412 (bcc9882) into develop (3677cc5) will decrease coverage by 6.69%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #30412      +/-   ##
===========================================
- Coverage    50.18%   43.50%   -6.69%     
===========================================
  Files          781      741      -40     
  Lines        14507    13481    -1026     
  Branches      2621     2485     -136     
===========================================
- Hits          7281     5865    -1416     
- Misses        6829     7270     +441     
+ Partials       397      346      -51     
Flag Coverage Δ
e2e 40.83% <ø> (-7.77%) ⬇️
unit 60.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@gabriellsh
Copy link
Member

Closing in favor of #30464

@gabriellsh gabriellsh closed this Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants