Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove connectToCloud option #30430

Merged
merged 2 commits into from
Sep 18, 2023
Merged

chore: remove connectToCloud option #30430

merged 2 commits into from
Sep 18, 2023

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Sep 18, 2023

NBJ-366

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@changeset-bot
Copy link

changeset-bot bot commented Sep 18, 2023

⚠️ No Changeset found

Latest commit: 9f74283

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ggazzo ggazzo force-pushed the chore/cloud-disconnect branch from f134dad to 11aa10d Compare September 18, 2023 15:32
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #30430 (9f74283) into develop (5ce4c41) will decrease coverage by 0.08%.
Report is 3 commits behind head on develop.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #30430      +/-   ##
===========================================
- Coverage    50.18%   50.11%   -0.08%     
===========================================
  Files          781      775       -6     
  Lines        14507    14460      -47     
  Branches      2621     2613       -8     
===========================================
- Hits          7281     7246      -35     
+ Misses        6829     6807      -22     
- Partials       397      407      +10     
Flag Coverage Δ
e2e 48.46% <100.00%> (-0.14%) ⬇️
unit 60.80% <0.00%> (+0.50%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo added this to the 6.5.0 milestone Sep 18, 2023
@ggazzo ggazzo marked this pull request as ready for review September 18, 2023 16:24
@ggazzo ggazzo requested review from a team as code owners September 18, 2023 16:24
tiagoevanp
tiagoevanp previously approved these changes Sep 18, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Sep 18, 2023
@ggazzo ggazzo merged commit 027b011 into develop Sep 18, 2023
43 checks passed
@ggazzo ggazzo deleted the chore/cloud-disconnect branch September 18, 2023 20:26
gabriellsh added a commit that referenced this pull request Sep 19, 2023
…ove/iframeLogin

* 'develop' of github.com:RocketChat/Rocket.Chat: (29 commits)
  fix: Disables `GenericMenu` without any sections or items (#30319)
  i18n: Language update from LingoHub 🤖 on 2023-09-18Z (#30426)
  chore:  remove connectToCloud option (#30430)
  chore: remove Troubleshoot options (#30429)
  chore: bump fuselage packages (#30424)
  chore: Webhooks page refactor (#30274)
  chore: color palette changes (#30385)
  fix: increase cron job check delay to 1 min (#30402)
  fix: Presence broadcast isn't enabled after license validation (#30282)
  test: create non private team and readonly team (#30371)
  Bump version to 6.5.0-develop
  refactor: Implement functional code for the 'useFilteredApps' hook (#30279)
  Release 6.4.0-rc.1
  Release 6.3.6
  regression: Login page callout messages (#30399)
  test: tests for muting and unmuting (#30286)
  regression: Fix rooms table not showing teams (#30361)
  regression: Move queue-timeout setting to CE and remove dependency on waiting queue (#30386)
  fix: engagement dashboard not working (#30277)
  Bump 6.3.6
  ...
debdutdeb pushed a commit that referenced this pull request Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants