Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: close button not working on contact history #30432

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

MartinSchoeler
Copy link
Contributor

OC-1298

@changeset-bot
Copy link

changeset-bot bot commented Sep 18, 2023

⚠️ No Changeset found

Latest commit: 2d2df40

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #30432 (2d2df40) into release-6.4.0 (f46c1f7) will decrease coverage by 0.02%.
Report is 4 commits behind head on release-6.4.0.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##           release-6.4.0   #30432      +/-   ##
=================================================
- Coverage          50.19%   50.18%   -0.02%     
=================================================
  Files                776      775       -1     
  Lines              14495    14491       -4     
  Branches            2618     2618              
=================================================
- Hits                7276     7272       -4     
+ Misses              6824     6810      -14     
- Partials             395      409      +14     
Flag Coverage Δ
e2e 48.60% <ø> (-0.02%) ⬇️
unit 60.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@MartinSchoeler MartinSchoeler added this to the 6.4.0 milestone Sep 19, 2023
@MartinSchoeler MartinSchoeler marked this pull request as ready for review September 19, 2023 13:25
@MartinSchoeler MartinSchoeler requested a review from a team as a code owner September 19, 2023 13:25
@ggazzo ggazzo merged commit f0de47c into release-6.4.0 Sep 19, 2023
41 checks passed
@ggazzo ggazzo deleted the fix-close-btn branch September 19, 2023 13:47
gabriellsh added a commit that referenced this pull request Sep 27, 2023
…ove/iframeLogin

* 'develop' of github.com:RocketChat/Rocket.Chat: (33 commits)
  feat: New records page analytics tab (#30373)
  chore: Changing some key translations - Setup Wizard (#30462)
  feat: use isolated-vm to run integration scripts (#30229)
  fix: do not broadcast events from the local node to the local service (duplicated event) (#30446)
  fix: Microsoft autotranslate not working (#30390)
  chore: `ResetPasswordPage` a11y improvements (#30479)
  chore: `ResetPasswordForm` a11y improvements (#30476)
  chore: Move bad words filter callback to service (#30241)
  fix: Message disappears from room after deletion even if "Show Deleted Status" is enabled (#30452)
  chore: add tooltip to mentions (#30445)
  chore: bump mongo deps (#30450)
  ci: patch mongo type definitions (#30449)
  chore: cache incremental ts check (#30447)
  Release 6.4.0-rc.4
  Release 6.4.0-rc.3
  chore: update meteor 2.13.0 (#29989)
  chore: Assertion accuracy on registration test (#30440)
  ci: Add step to notify external services about a new release after Docker image publish (#30436)
  regression: close button not working on contact history (#30432)
  regression: custom fields not showing in current chats (#30428)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants