-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: NBJ watermark support for new licenses #30469
Conversation
|
Codecov Report
@@ Coverage Diff @@
## develop #30469 +/- ##
===========================================
- Coverage 51.22% 50.98% -0.24%
===========================================
Files 811 809 -2
Lines 15113 15218 +105
Branches 2759 2827 +68
===========================================
+ Hits 7741 7759 +18
- Misses 6961 7016 +55
- Partials 411 443 +32
Flags with carried forward coverage won't be shown. Click here to find out more. |
6ad0bc8
to
7e02442
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @aleksandernsilva you can rebase your PR to develop branch and implement the correct behavior with the License...
I also suggest to use a more generic name for water mark module, like "watermark"
007045b
to
ec0893e
Compare
c09e6d6
to
50bac2f
Compare
apps/meteor/ee/client/sidebar/footer/SidebarFooterWatermark.tsx
Outdated
Show resolved
Hide resolved
d453da4
to
0021b05
Compare
apps/meteor/ee/client/sidebar/footer/SidebarFooterWatermark.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the useLicense() hooks has changed, update with your branch and make the necessary changes
@aleksandernsilva can you fix the conflicts? |
076f1f3
to
4262540
Compare
apps/meteor/ee/client/sidebar/footer/SidebarFooterWatermark.tsx
Outdated
Show resolved
Hide resolved
apps/meteor/ee/client/sidebar/footer/SidebarFooterWatermark.tsx
Outdated
Show resolved
Hide resolved
b92bd7a
to
5ca32d5
Compare
f4b2b7c
to
ed3edb5
Compare
ed3edb5
to
c171de3
Compare
Proposed changes (including videos or screenshots)
Issue(s)
NBJ-377
Steps to test or reproduce
Further comments