regression: multiselect #30472
Merged
regression: multiselect #30472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0ad2743 The changes in this PR will be included in the next version bump. This PR includes changesets to release 29 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## release-6.4.0 #30472 +/- ##
=================================================
+ Coverage 50.09% 50.22% +0.13%
=================================================
Files 775 774 -1
Lines 14491 14447 -44
Branches 2618 2611 -7
=================================================
- Hits 7259 7256 -3
+ Misses 6839 6785 -54
- Partials 393 406 +13
Flags with carried forward coverage won't be shown. Click here to find out more. |
Fixed the fooms page filters behavior, instead of selecting all options it selects none and filters according to the ones the user selected or un-selected.
ggazzo
force-pushed
the
regression/multiselect
branch
from
6fe98ca to
0ad2743
Compare
rique223
approved these changes
Sep 22, 2023
4ac03822dd9d4a7aa3bbf6d61b067a45.mp4 |
dionisio-bot
bot
added
the
stat: ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Jira task: WM-181
Fixed a bug in which the rooms page filters would not behave correctly due to the production React strict mode in conjunction with some poorly writen code.
Demo gif with --production flag:
Issue(s)
Steps to test or reproduce
Further comments