Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: Rooms page filter #30477

Closed
wants to merge 1 commit into from

Conversation

rique223
Copy link
Contributor

@rique223 rique223 commented Sep 22, 2023

Proposed changes (including videos or screenshots)

Fixed a bug in which the rooms page filters would not behave correctly due to the production environment strict mode in conjunction with some poorly writen code.

Demo gif with --production flag:
rooms_filter_regression

Issue(s)

Steps to test or reproduce

Further comments

@changeset-bot
Copy link

changeset-bot bot commented Sep 22, 2023

⚠️ No Changeset found

Latest commit: 4eb9186

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Merging #30477 (4eb9186) into release-6.4.0 (ac48589) will decrease coverage by 4.29%.
The diff coverage is 0.00%.

Impacted file tree graph

@@                Coverage Diff                @@
##           release-6.4.0   #30477      +/-   ##
=================================================
- Coverage          50.09%   45.80%   -4.29%     
=================================================
  Files                775      767       -8     
  Lines              14491    14255     -236     
  Branches            2618     2615       -3     
=================================================
- Hits                7259     6530     -729     
- Misses              6839     7328     +489     
- Partials             393      397       +4     
Flag Coverage Δ
e2e 43.67% <ø> (-4.84%) ⬇️
unit 60.39% <0.00%> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@rique223 rique223 closed this Sep 25, 2023
@rique223 rique223 deleted the regression/rooms-filters-behavior branch September 25, 2023 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant